imagecache: coverity - fix wrong unlink() call

tvheadend · Oct 3, 2014 · 07d5b11 · 07d5b11
1 parent a7e6993
commit 07d5b11
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/imagecache.c b/src/imagecache.c
@@ -139,7 +139,7 @@ imagecache_image_fetch ( imagecache_image_t *img )
   int res = 1, r;
   FILE *fp = NULL;
   url_t url;
-  char tmp[256], path[256];
+  char tmp[256] = "", path[256];
   tvhpoll_event_t ev;
   tvhpoll_t *efd = NULL;
   http_client_t *hc;
@@ -215,7 +215,8 @@ imagecache_image_fetch ( imagecache_image_t *img )
   time(&img->updated); // even if failed (possibly request sooner?)
   if (res) {
     img->failed = 1;
-    unlink(tmp);
+    if (tmp[0])
+      unlink(tmp);
     tvhlog(LOG_WARNING, "imagecache", "failed to download %s", img->url);
   } else {
     img->failed = 0;