avoid leaving dangling children by killing spawned processes recursively

tvheadend · Apr 9, 2015 · 14f03b8 · 14f03b8
1 parent 02427fe
commit 14f03b8
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/spawn.c b/src/spawn.c
@@ -299,7 +299,8 @@ spawn_kill(pid_t pid, int sig)
       if(s->pid == pid)
         break;
     if (s) {
-      r = kill(pid, sig);
+      /* kill the whole process group */
+      r = kill(-pid, sig);
       if (r < 0)
         r = -errno;
     }
@@ -502,8 +503,14 @@ spawn_and_give_stdout(const char *prog, char *argv[], char *envp[],
   close(fd[1]);
 
   *rd = fd[0];
-  if (pid)
+  if (pid) {
     *pid = p;
+
+    // make the spawned process a session leader so killing the
+    // process group recursively kills any child process that
+    // might have been spawned
+    setpgid(p, p);
+  }
   return 0;
 }