http server: fix memory leak in http_redirect (loc)

tvheadend · Jun 16, 2016 · 24bc73b · 24bc73b
1 parent 8f9aa30
commit 24bc73b
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/http.c b/src/http.c
@@ -638,7 +638,7 @@ http_redirect(http_connection_t *hc, const char *location,
     loc = htsbuf_to_string(&hq);
     htsbuf_queue_flush(&hq);
   } else if (!external && tvheadend_webroot && location[0] == '/') {
-    loc = alloca(strlen(location) + strlen(tvheadend_webroot) + 1);
+    loc = malloc(strlen(location) + strlen(tvheadend_webroot) + 1);
     strcpy((char *)loc, tvheadend_webroot);
     strcat((char *)loc, location);
   }
@@ -653,6 +653,9 @@ http_redirect(http_connection_t *hc, const char *location,
 		 loc, loc);
 
   http_send_reply(hc, HTTP_STATUS_FOUND, "text/html", NULL, loc, 0);
+
+  if (loc != location)
+    free(loc);
 }