htsmsg: fix htsmsg_get_str_multi() - coverity

tvheadend · Oct 3, 2014 · 36166ca · 36166ca
1 parent 297c79c
commit 36166ca
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/htsmsg.c b/src/htsmsg.c
@@ -667,23 +667,24 @@ const char *
 htsmsg_get_str_multi(htsmsg_t *msg, ...)
 {
   va_list ap;
-  const char *n;
+  const char *n, *r = NULL;
   htsmsg_field_t *f;
 
   va_start(ap, msg);
   while((n = va_arg(ap, char *)) != NULL) {
     if((f = htsmsg_field_find(msg, n)) == NULL)
       break;
-    else if(f->hmf_type == HMF_STR)
-      return f->hmf_str;
-    else if(f->hmf_type == HMF_MAP)
+    else if(f->hmf_type == HMF_STR) {
+      r = f->hmf_str;
+      break;
+    } else if(f->hmf_type == HMF_MAP)
       msg = &f->hmf_msg;
     else
       break;
   }
   va_end(ap);
 
-  return NULL;
+  return r;
 }