Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
support: replace /bin/bash with /bin/sh for FreeBSD - fixes issue#2192
  • Loading branch information
perexg committed Aug 13, 2014
1 parent 261536c commit 7d3a65d
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion support/changelog
@@ -1,4 +1,4 @@
#!/bin/bash
#!/bin/sh
#
# Create the Tvheadend changelog
#
Expand Down
2 changes: 1 addition & 1 deletion support/configure.inc
@@ -1,4 +1,4 @@
#!/bin/bash
#!/bin/sh
#
# Generic/Simple configure script
#
Expand Down
2 changes: 1 addition & 1 deletion support/getmuxlist
@@ -1,4 +1,4 @@
#!/bin/bash
#!/bin/sh
#
# Fetch DVB scan files
#
Expand Down
2 changes: 1 addition & 1 deletion support/tarball
@@ -1,4 +1,4 @@
#!/bin/bash
#!/bin/sh

This comment has been minimized.

Copy link
@dreamcat4

dreamcat4 Aug 16, 2014

Contributor

@ksooo well, that wasn't the only script affected. All of it is fixed in pull request #459. It already includes your fix for the support/tarball script. Just that @perexg hasn't merged it yet.

#
# Build tarball of the current directory
#
Expand Down
2 changes: 1 addition & 1 deletion support/version
@@ -1,4 +1,4 @@
#!/bin/bash
#!/bin/sh
#
# Update Tvheadend version file (if required)
#
Expand Down

3 comments on commit 7d3a65d

@dreamcat4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @perexg !

Bear in mind that on some systems /bin/sh points to bash command. Let's hope there isn't any bash-specific syntax to break anything. Did you have a chance to use the recommended program shellcheck to confirm the scripts are OK?

@dreamcat4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perexg The only thing is that configure.inc still needs bash for is the bash arrays.

All of the minor POSIX fixes in pull request #459.

@ksooo
Copy link
Contributor

@ksooo ksooo commented on 7d3a65d Aug 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perexg please merge #459 soon to fix the different problems introduced with this commit. Thanks.

Please sign in to comment.