Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
stream type: distinguish between AAC-LC/HE and newer AAC-LATM/LOAS
  • Loading branch information
@perexg
perexg committed Aug 4, 2014
1 parent cb74275 commit 8289df7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/streaming.c
View file
Expand Up @@ -505,7 +505,7 @@ static struct strtab streamtypetab[] = {
{ "MPEGTS", SCT_MPEGTS },
{ "TEXTSUB", SCT_TEXTSUB },
{ "EAC3", SCT_EAC3 },
{ "AAC", SCT_MP4A },
{ "AAC-LATM", SCT_MP4A },
{ "VP8", SCT_VP8 },
{ "VORBIS", SCT_VORBIS },
{ "HEVC", SCT_HEVC },
Expand Down

2 comments on commit 8289df7

@linuxstb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not understanding this at all. How does this distinguish anything - you've just changed all to be called AAC-LATM.

IIUC, this will break htsp clients (at the very least it breaks my pidvbip), as these strings are used as the stream type identifiers. In addition, LATM is just a bitstream packing format for AAC (the other common packing is ADTS), it has nothing to do with the actual content of the AAC stream.

@perexg
Copy link
Contributor Author

@perexg perexg commented on 8289df7 Aug 6, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took this identification from ffmpeg. Basically, in the MPEG-TS, there are two identifications for AAC - 0x0f and 0x11 - see src/input/mpegts/dvb_psi.c . For PID filtering, we need to distinguish the types, but it's true that for clients (players), it does not matter, because they'll detect the stream packing automatically.

I tried to fix this in 37a1aab .

Please sign in to comment.