Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
WEBUI JS: epg details dialog - move some styling to css
  • Loading branch information
@perexg
perexg committed Sep 28, 2014
1 parent e95576b commit 8667a57
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
6 changes: 3 additions & 3 deletions src/webui/static/app/epg.js
View file
Expand Up @@ -98,11 +98,11 @@ tvheadend.epgDetails = function(event) {
content += " : " + event.subtitle;
content += '</div>';
if (event.episodeOnscreen)
content += '<div class="x-epg-desc">' + event.episodeOnscreen + '</div>';
content += '<div class="x-epg-title">' + event.episodeOnscreen + '</div>';
if (event.summary)
content += '<div class="x-epg-desc"><b>' + event.summary + '</b></div>';
content += '<div class="x-epg-summary">' + event.summary + '</div>';
if (event.description)
content += '<div class="x-epg-desc"><p>' + event.description + '</p></div>';
content += '<div class="x-epg-desc">' + event.description + '</div>';
if (event.starRating)
content += '<div class="x-epg-meta">Star Rating: ' + event.starRating + '</div>';
if (event.ageRating)
Expand Down
7 changes: 6 additions & 1 deletion src/webui/static/app/ext.css
View file
Expand Up @@ -349,8 +349,13 @@
font-weight: bold;
}

.x-epg-desc {
.x-epg-summary {
margin: 5px;
font-weight: bold;
}

.x-epg-desc {
margin: 10px;
}

.x-epg-chicon {
Expand Down

6 comments on commit 8667a57

@ProfYaffle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't like this, but happy to be over-ruled by mass opinion (who am I, anyway :) ). I'd go bold title, regular description, italic footnotes, something like that.

@perexg
Copy link
Contributor Author

@perexg perexg commented on 8667a57 Sep 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did further styling, but I think that each people have different visual feeling, so it may not catch yours..

Actually, the title is bold with large fort, then subtitle (bold, smaller font) then short summary is bold with standard fort and the big description is with normal font.. The other info like rating and content type is italic now. The I made also links bold now for a better navigation.

If you like another presentation, create a patch to consider the change..

@ProfYaffle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More than happy to patch it if I feel that strongly :-)

Let's see what anyone else has to say. I think the issue is in the EPG data I receive: I have no normal font/big description on any event on -T or -S, only the small/bold subtitle entry. It may be unique to me, or unique to the UK, in which case life's like that!

Cheers...

@kevjs1982
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ProfYaffle - the UK information is rather limited compared with the German broadcasters on Astra 19.2'E, the Gemran commercial channels don't usually put the episode name inside synopsis like the BBC and ITV do.

To give you an idea of what you can see
rtl - the bit after the ":" is the subtitle which XBMC displays on a different line.

This is actually via XMLTV but OTA is similar - the description is usually much shorter on the OTA stuff usually - alas my dish won't be up again until the Russian GP at the end of October and the stuff which is OTA is now over 7 days old so expunged from the history.

@ProfYaffle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevjs1982 That makes a degree of sense - it explains where the normal weight text has gone, at least!

This is what I get with 3.9.1592~g8fa6977:

screenshot - 290914 - 15 35 45

It's cosmetic at the end of the day.

@kevjs1982
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ukvsde
FYI the attached is how it looks in 3.9.1987 on German channel ZDF (satellite EIT) vs BBC ONE from Freeview.

Please sign in to comment.