allow NVENC, VAAPI and MMAL to coexist in the same build

- allow NVENC, VAAPI and MMAL to coexist in the same build.
- give the user the capability for prioritize hw decoder or to match the hw decoder with hw encoder
- refactor source code: remove duplicate source code in codec.js

Author: uknunknown

src/transcoding/codec.h

@@ -136,6 +136,9 @@ tvh_codec_profile_video_destroy(TVHCodecProfile *_self);
 int
 tvh_codec_profile_video_get_hwaccel(TVHCodecProfile *self);
 
+int
+tvh_codec_profile_video_get_hwaccel_details(TVHCodecProfile *self);
+
 const enum AVPixelFormat *
 tvh_codec_profile_video_get_pix_fmts(TVHCodecProfile *self);
 

src/transcoding/codec/internals.h

@@ -119,6 +119,16 @@
     AV_DICT_SET_INT((d), "pix_fmt", ((v) != AV_PIX_FMT_NONE) ? (v) : (a), \
                     AV_DICT_DONT_OVERWRITE)
 
+#define HWACCEL_AUTO        0
+#if ENABLE_VAAPI
+#define HWACCEL_PRIORITIZE_VAAPI 1
+#endif
+#if ENABLE_NVENC
+#define HWACCEL_PRIORITIZE_NVDEC 2
+#endif
+#if ENABLE_MMAL
+#define HWACCEL_PRIORITIZE_MMAL  3
+#endif
 
 /* codec_profile_class ====================================================== */
 
@@ -221,6 +231,7 @@ typedef struct tvh_codec_profile_video {
     int height;
     int scaling_mode;   // 0 --> up&down; 1 --> up; 2 --> down
     int hwaccel;
+    int hwaccel_details;
     int pix_fmt;
     int crf;
     AVRational size;

src/transcoding/codec/profile.c

@@ -286,6 +286,18 @@ tvh_codec_profile_video_get_hwaccel(TVHCodecProfile *self)
     return -1;
 }
 
+
+int
+tvh_codec_profile_video_get_hwaccel_details(TVHCodecProfile *self)
+{
+    TVHCodec *codec = tvh_codec_profile_get_codec(self);
+    if (codec && tvh_codec_is_enabled(codec) &&
+        tvh_codec_get_type(codec) == AVMEDIA_TYPE_VIDEO) {
+        return ((TVHVideoCodecProfile *)self)->hwaccel_details;
+    }
+    return -1;
+}
+
 const enum AVPixelFormat *
 tvh_codec_profile_video_get_pix_fmts(TVHCodecProfile *self)
 {

src/transcoding/codec/profile_video_class.c

@@ -33,6 +33,25 @@ scaling_mode_get_list( void *o, const char *lang )
     return strtab2htsmsg(tab, 1, lang);
 }
 
+static htsmsg_t *
+hwaccel_get_list( void *o, const char *lang )
+{
+    static const struct strtab tab[] = {
+        { N_("auto (recommended)"),                 HWACCEL_AUTO},
+#if ENABLE_VAAPI
+        { N_("prioritize VAAPI"),                   HWACCEL_PRIORITIZE_VAAPI},
+#endif
+#if ENABLE_NVENC
+        { N_("prioritize NVDEC"),                   HWACCEL_PRIORITIZE_NVDEC},
+#endif
+#if ENABLE_MMAL
+        { N_("prioritize MMAL"),                    HWACCEL_PRIORITIZE_MMAL},
+#endif
+    };
+    return strtab2htsmsg(tab, 1, lang);
+}
+
+
 /* TVHCodec ================================================================= */
 
 static htsmsg_t *
@@ -215,6 +234,16 @@ const codec_profile_class_t codec_profile_video_class = {
                 .off      = offsetof(TVHVideoCodecProfile, hwaccel),
                 .def.i    = 0,
             },
+            {
+                .type     = PT_INT,
+                .id       = "hwaccel_details",
+                .name     = N_("Hardware acceleration details"),
+                .desc     = N_("Force hardware acceleration."),
+                .group    = 2,
+                .off      = offsetof(TVHVideoCodecProfile, hwaccel_details),
+                .list     = hwaccel_get_list,
+                .def.i    = 0,
+            },
             {
                 .type     = PT_INT,
                 .id       = "pix_fmt",

src/transcoding/transcode/stream.c

@@ -57,16 +57,26 @@ tvh_stream_setup(TVHStream *self, TVHCodecProfile *profile, tvh_ssc_t *ssc)
 {
     enum AVCodecID icodec_id = streaming_component_type2codec_id(ssc->es_type);
     const AVCodec *icodec = NULL, *ocodec = NULL;
+    int hwaccel = -1;
+    int hwaccel_details = -1;
 
     if (icodec_id == AV_CODEC_ID_NONE) {
         tvh_stream_log(self, LOG_ERR, "unknown decoder id for '%s'",
                        streaming_component_type2txt(ssc->es_type));
         return -1;
     }
+    if ((hwaccel = tvh_codec_profile_video_get_hwaccel(profile)) < 0) {
+        return -1;
+    }
+    if ((hwaccel_details = tvh_codec_profile_video_get_hwaccel_details(profile)) < 0) {
+        return -1;
+    }
 #if ENABLE_MMAL
     if (idnode_is_instance(&profile->idnode,
                            (idclass_t *)&codec_profile_video_class)) {
-      if (tvh_codec_profile_video_get_hwaccel(profile) > 0) {
+      if (hwaccel &&
+         ((hwaccel_details == HWACCEL_AUTO && strstr(profile->codec_name, "mmal")) ||
+         hwaccel_details == HWACCEL_PRIORITIZE_MMAL)) {
         if (icodec_id == AV_CODEC_ID_H264) {
             icodec = avcodec_find_decoder_by_name("h264_mmal");
         } else if (icodec_id == AV_CODEC_ID_MPEG2VIDEO) {
@@ -76,16 +86,40 @@ tvh_stream_setup(TVHStream *self, TVHCodecProfile *profile, tvh_ssc_t *ssc)
     }
 #endif
 #if ENABLE_NVENC
-    if (idnode_is_instance(&profile->idnode,
+    if (!icodec && idnode_is_instance(&profile->idnode,
                            (idclass_t *)&codec_profile_video_class)) {
-      if (tvh_codec_profile_video_get_hwaccel(profile) > 0) {
+      if (hwaccel &&
+         ((hwaccel_details == HWACCEL_AUTO && strstr(profile->codec_name, "nvenc")) ||
+         hwaccel_details == HWACCEL_PRIORITIZE_NVDEC)) {
+        // https://developer.nvidia.com/video-codec-sdk
         if (icodec_id == AV_CODEC_ID_H264) {
             icodec = avcodec_find_decoder_by_name("h264_cuvid");
         } else if (icodec_id == AV_CODEC_ID_HEVC) {
             icodec = avcodec_find_decoder_by_name("hevc_cuvid");
         }
       }
     }
+#endif
+#if ENABLE_VAAPI
+    if (!icodec && idnode_is_instance(&profile->idnode,
+                           (idclass_t *)&codec_profile_video_class)) {
+      if (hwaccel &&
+        (hwaccel_details == HWACCEL_PRIORITIZE_VAAPI)) {
+        if (icodec_id == AV_CODEC_ID_MPEG2VIDEO) {
+            icodec = avcodec_find_decoder_by_name("mpeg2_vaapi");
+        } else if (icodec_id == AV_CODEC_ID_H264) {
+            icodec = avcodec_find_decoder_by_name("h264_vaapi");
+        } else if (icodec_id == AV_CODEC_ID_HEVC) {
+            icodec = avcodec_find_decoder_by_name("hevc_vaapi");
+        } else if (icodec_id == AV_CODEC_ID_VP9) {
+            icodec = avcodec_find_decoder_by_name("vp9_vaapi");
+        } else if (icodec_id == AV_CODEC_ID_VP8) {
+            icodec = avcodec_find_decoder_by_name("vp8_vaapi");
+        }else if (icodec_id == AV_CODEC_ID_MJPEG) {
+            icodec = avcodec_find_decoder_by_name("mjpeg_vaapi");
+        }
+      }
+    }
 #endif
     if (!icodec && !(icodec = avcodec_find_decoder(icodec_id))) {
         tvh_stream_log(self, LOG_ERR, "failed to find decoder for '%s'",