Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
idnode: fix get functions (islist) - coverity
  • Loading branch information
perexg committed Oct 3, 2014
1 parent f0e4ec0 commit d5712f1
Showing 1 changed file with 15 additions and 10 deletions.
25 changes: 15 additions & 10 deletions src/idnode.c
Expand Up @@ -376,10 +376,11 @@ idnode_get_u32
( idnode_t *self, const char *key, uint32_t *u32 )
{
const property_t *p = idnode_find_prop(self, key);
if (p->islist) return 1;
if (p) {
const void *ptr;
if (p->get)
if (p->islist)
return 1;
else if (p->get)
ptr = p->get(self);
else
ptr = ((void*)self) + p->off;
Expand Down Expand Up @@ -409,10 +410,11 @@ idnode_get_s64
( idnode_t *self, const char *key, int64_t *s64 )
{
const property_t *p = idnode_find_prop(self, key);
if (p->islist) return 1;
if (p) {
const void *ptr;
if (p->get)
if (p->islist)
return 1;
else if (p->get)
ptr = p->get(self);
else
ptr = ((void*)self) + p->off;
Expand Down Expand Up @@ -451,10 +453,11 @@ idnode_get_dbl
( idnode_t *self, const char *key, double *dbl )
{
const property_t *p = idnode_find_prop(self, key);
if (p->islist) return 1;
if (p) {
const void *ptr;
if (p->get)
if (p->islist)
return 1;
else if (p->get)
ptr = p->get(self);
else
ptr = ((void*)self) + p->off;
Expand Down Expand Up @@ -493,10 +496,11 @@ idnode_get_bool
( idnode_t *self, const char *key, int *b )
{
const property_t *p = idnode_find_prop(self, key);
if (p->islist) return 1;
if (p) {
if (p) {
const void *ptr;
if (p->get)
if (p->islist)
return 1;
else if (p->get)
ptr = p->get(self);
else
ptr = ((void*)self) + p->off;
Expand All @@ -519,9 +523,10 @@ idnode_get_time
( idnode_t *self, const char *key, time_t *tm )
{
const property_t *p = idnode_find_prop(self, key);
if (p->islist) return 1;
if (p) {
const void *ptr;
if (p->islist)
return 1;
if (p->get)
ptr = p->get(self);
else
Expand Down

0 comments on commit d5712f1

Please sign in to comment.