Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
SAT>IP client: add RTCP workaround for broken servers (minisatip)
  • Loading branch information
perexg committed Apr 13, 2015
1 parent 6751ade commit daaebf9
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/input/mpegts/satip/satip_frontend.c
Expand Up @@ -703,11 +703,12 @@ satip_frontend_decode_rtcp( satip_frontend_t *lfe, const char *name,
if ((rtcp[0] & 0xc0) != 0x80) /* protocol version: v2 */
return;
l = (((rtcp[2] << 8) | rtcp[3]) + 1) * 4; /* length of payload */
if (l > len)
return;
if (rtcp[1] == 204 && l > 20 && /* packet type */
rtcp[8] == 'S' && rtcp[9] == 'E' &&
rtcp[10] == 'S' && rtcp[11] == '1') {
/* workaround for broken minisatip */
if (l > len && l - 4 != len)
return;
sl = (rtcp[14] << 8) | rtcp[15];
if (sl > 0 && l - 16 >= sl) {
rtcp[sl + 16] = '\0';
Expand Down

3 comments on commit daaebf9

@9000h
Copy link

@9000h 9000h commented on daaebf9 Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Perexg,
found your commit/comment here about minisatip, can you please explain the workaround an is there a possible fix for minisatip?
CU
9000h

@perexg
Copy link
Contributor Author

@perexg perexg commented on daaebf9 Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already fixed in minisatip (catalinii/minisatip@46e60c5).

@9000h
Copy link

@9000h 9000h commented on daaebf9 Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, great

Please sign in to comment.