Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
tcp: show the TCP server binding in log
  • Loading branch information
perexg committed Nov 30, 2015
1 parent 3d9eae2 commit dcc0324
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 14 deletions.
4 changes: 2 additions & 2 deletions src/htsp_server.c
Expand Up @@ -3224,9 +3224,9 @@ htsp_init(const char *bindaddr)
.stop = NULL,
.cancel = htsp_server_cancel
};
htsp_server = tcp_server_create(bindaddr, tvheadend_htsp_port, &ops, NULL);
htsp_server = tcp_server_create("htsp", "HTSP", bindaddr, tvheadend_htsp_port, &ops, NULL);
if(tvheadend_htsp_port_extra)
htsp_server_2 = tcp_server_create(bindaddr, tvheadend_htsp_port_extra, &ops, NULL);
htsp_server_2 = tcp_server_create("htsp", "HTSP2", bindaddr, tvheadend_htsp_port_extra, &ops, NULL);
}

/*
Expand Down
2 changes: 1 addition & 1 deletion src/http.c
Expand Up @@ -1222,7 +1222,7 @@ http_server_init(const char *bindaddr)
.stop = NULL,
.cancel = http_cancel
};
http_server = tcp_server_create(bindaddr, tvheadend_webui_port, &ops, NULL);
http_server = tcp_server_create("http", "HTTP", bindaddr, tvheadend_webui_port, &ops, NULL);
}

void
Expand Down
2 changes: 1 addition & 1 deletion src/satip/rtsp.c
Expand Up @@ -1614,7 +1614,7 @@ void satip_server_rtsp_init
rtsp_nat_ip = nat_ip ? strdup(nat_ip) : NULL;
free(s);
if (!rtsp_server)
rtsp_server = tcp_server_create(bindaddr, port, &ops, NULL);
rtsp_server = tcp_server_create("satips", "SAT>IP RTSP", bindaddr, port, &ops, NULL);
if (reg)
tcp_server_register(rtsp_server);
}
Expand Down
22 changes: 14 additions & 8 deletions src/tcp.c
Expand Up @@ -738,20 +738,18 @@ tcp_server_loop(void *aux)
*
*/
#if ENABLE_LIBSYSTEMD_DAEMON
static void *
tcp_server_create_new
(const char *bindaddr, int port, tcp_server_ops_t *ops, void *opaque)
static void *tcp_server_create_new
#else
void *
tcp_server_create
(const char *bindaddr, int port, tcp_server_ops_t *ops, void *opaque)
void *tcp_server_create
#endif
(const char *subsystem, const char *name, const char *bindaddr,
int port, tcp_server_ops_t *ops, void *opaque)
{
int fd, x;
tcp_server_t *ts;
struct addrinfo hints, *res, *ressave, *use = NULL;
struct sockaddr_storage bound;
char port_buf[6];
char port_buf[6], buf[50];
int one = 1;
int zero = 0;

Expand Down Expand Up @@ -815,6 +813,10 @@ tcp_server_create
ts->bound = bound;
ts->ops = *ops;
ts->opaque = opaque;

tcp_get_str_from_ip((const struct sockaddr *)&bound, buf, sizeof(buf));
tvhlog(LOG_INFO, subsystem, "Starting %s server %s:%d", name, buf, htons(IP_PORT(bound)));

return ts;
}

Expand All @@ -824,13 +826,15 @@ tcp_server_create
*/
void *
tcp_server_create
(const char *bindaddr, int port, tcp_server_ops_t *ops, void *opaque)
(const char *subsystem, const char *name, const char *bindaddr,
int port, tcp_server_ops_t *ops, void *opaque)
{
int sd_fds_num, i, fd;
struct sockaddr_storage bound;
tcp_server_t *ts;
struct in_addr addr4;
struct in6_addr addr6;
char buf[50];
int found = 0;

sd_fds_num = sd_listen_fds(0);
Expand Down Expand Up @@ -876,6 +880,8 @@ tcp_server_create
ts->bound = bound;
ts->ops = *ops;
ts->opaque = opaque;
tcp_get_str_from_ip((const struct sockaddr *)&bound, buf, sizeof(buf));
tvhlog(LOG_INFO, subsystem, "Starting %s server %s:%d (systemd)", subsystem, name, buf, htons(IP_PORT(bound)));
} else {
/* no systemd-managed socket found, create a new one */
tvhlog(LOG_INFO, "tcp", "No systemd socket: creating a new one");
Expand Down
5 changes: 3 additions & 2 deletions src/tcp.h
Expand Up @@ -67,8 +67,9 @@ typedef void (tcp_server_callback_t)(int fd, void *opaque,
struct sockaddr_storage *peer,
struct sockaddr_storage *self);

void *tcp_server_create(const char *bindaddr, int port,
tcp_server_ops_t *ops, void *opaque);
void *tcp_server_create(const char *subsystem, const char *name,
const char *bindaddr, int port,
tcp_server_ops_t *ops, void *opaque);

void tcp_server_register(void *server);

Expand Down

0 comments on commit dcc0324

Please sign in to comment.