webui, htsbuf: Content-Disposition escape chars are not correct. #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to download a recording with a comma Google Chrome will fail with ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION. This is because the comma ',' in the filename*=UTF-8'' field was not escaped. This commit implements the defined list of non-escape characters from RFC8187 based on htsbuf_append_and_escape_url. The same problem occurs in issue #2086. Fixed in 2fdfe48 "webui: fix the attachment; filename encoding, fixes #2086" and broken again in ab9fc24 "fix htsbuf_append_and_escape_url() - don't escape more allowed characters, fixes #3721". Only tested in release/4.2. https://bugs.chromium.org/p/chromium/issues/detail?id=454165
|
Merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to download a recording with a comma Google Chrome will
fail with ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION. This is
because the comma ',' in the filename*=UTF-8'' field was not escaped.
This commit implements the defined list of non-escape characters from
RFC8187 based on htsbuf_append_and_escape_url.
The same problem occurs in issue #2086. Fixed in 2fdfe48 "webui: fix the
attachment; filename encoding, fixes #2086" and broken again in ab9fc24
"fix htsbuf_append_and_escape_url() - don't escape more allowed characters,
fixes #3721".
Only tested in release/4.2.
https://bugs.chromium.org/p/chromium/issues/detail?id=454165