Status display - User access list Feature #1173 #164
Conversation
as a config parameter not an in-memory storage
config options not in-memory structure (for runtime logging)
Fixed search and display routine (will dump current user database on a status.xml request) And user information automatically updated at each http or htsp request.
Now outputs logs in the format: Sep 17 10:30:04 [DEBUG]:accesscontrol: Logging structure al->id: 2 Sep 17 10:30:04 [DEBUG]:accesscontrol: Logging structure al->username: andyb Sep 17 10:30:04 [DEBUG]:accesscontrol: Logging structure al->startlog: 1347874194 Sep 17 10:30:04 [DEBUG]:accesscontrol: Logging structure al->currlog: 1347874204 Sep 17 10:30:04 [DEBUG]:accesscontrol: Logging structure al->ip: 192.168.2.94 Sep 17 10:30:04 [DEBUG]:accesscontrol: Logging structure al->type: http
displays contents of the access_log database
suggestion Re-do initial logging initialisation code
Conflicts: src/webui/simpleui.c
a destroy event to remove when client disconnects (hopefully)
logs honoured, so status.xml now shows active htsp and will remove htsp client/user on stop subscription
for htsp subscriptions by parsing the log data string
Conflicts: src/access.h src/htsp.c
Tidy code
Added column headings
- problem with data not appearing
Also merged
DVR recordings now logged
|
Hi Andy - nice work - can you change status_userlist.js to have a relative url, just for the guys that have tvheadend behind a reserve proxy. url : '/status/userlist', -> url : 'status/userlist', I have test this change. |
|
@andyb2000 it would be great if you can squash all your commits, so it's only one commit |
|
@andyb2000 I wouldn't worry about squashing stuff in PRs I will always do that before I push to master anyway. |
|
@andyb2000 I need a proper chance to review this, but to do that I need to be on a machine at home. So I'm gonna have to leave this for a bit. |
url : '/status/userlist', -> url : 'status/userlist', To handle reverse proxy a little better
|
Just noticed a push with similar code added by andoma, was this part of this PR or are you still reviewing this Adam? Adam Sutton notifications@github.com wrote:
Sent from my Android phone with K-9 Mail. Please excuse my brevity. |
|
@andyb2000 yeah sorry about that, I did point @andoma at your PR and he was originally going to pull it and modify I think. But I'm not sure whether he ended up doing it from scratch. Maybe its worth taking a look at what he's done and seeing how well it aligns and whether you can add to what he's done. Adam |
|
@andyb2000 I've had a look at @andoma's version and I don't think his includes everything you were planning to add, however he might also be adding more to his. I think it would be a good idea to chat it over with him and see whether its worth you continuing what you're doing and simply incorporate into his etc... Adam |
ghost
assigned 
Adds the tab "Status" and sub-tab "User Access List" which lists which users/devices are connected to TVH.
Entries include http to the Webui and HTSP for streaming. Shows IP of device/user connected and if HTSP also the channel being streamed.