Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strong link between dvr_entry and channel #185

Closed
wants to merge 1 commit into from

Conversation

krka
Copy link
Contributor

@krka krka commented Dec 21, 2012

Fixes:

  • Recordings getting deleted if a channel gets deleted
  • Upon channel rename, all recordings will also
    get the channel name updated.

@adamsutton
Copy link
Contributor

@krka not sure I like this approach. I'd prefer we keep the link, but also duplicate channel name for printing purposes in case channel link is lost, say on restart.

What we definitely do need, which I think was your original intention, is to remove choose that deletes recordings iv channel delete.

Will try and catch you on IRC, as I think some of the same methods will also need to be applied to other stuff like epg metadata.

Adam

@krka
Copy link
Contributor Author

krka commented Dec 22, 2012

I don't see the benefit of keeping the hard link, since there's already a 1:1 mapping between channels and channel ames. For historic data, I don't think there should be any referencess to configurable/removable entities.

Fixes:
* Recordings getting deleted if a channel gets deleted
* Upon channel rename, all recordings will also
  get the channel name updated.
@adamsutton
Copy link
Contributor

@krka is this dead now and replaced by the new PR?

@krka
Copy link
Contributor Author

krka commented Jan 26, 2013

Yes, only one of them is necessary. I guess you get to choose which one is best.

@adamsutton adamsutton closed this Jan 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants