Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid dups #301

Merged
merged 3 commits into from Jun 7, 2014
Merged

Avoid dups #301

merged 3 commits into from Jun 7, 2014

Conversation

cleanrock
Copy link
Contributor

No description provided.

@ckarrie
Copy link
Contributor

ckarrie commented May 27, 2014

@cleanrock First question: Hi, could you please sign the CLA to get this in TVH? Second: Is it possible to compare the description to avoid duplicates?

@cleanrock
Copy link
Contributor Author

That looks odd, if i agree it looks like jasonm will have write access to my public repos.
Looks like hijacking to me, perhaps i dont understand this odd agreement but tvheadend devs are welcome to use my changes.

@ProfYaffle
Copy link
Member

@cleanrock That isn't the intention - it should just record on github that you've agreed and then it's all done. No hijacking intended, I'm sure of that. @adamsutton, any comment, perhaps from the perspective of the CLA 'quirks' you've been seeing?

If you have no intention of pushing further code, you can sign it offline, but I believe the github approach is mandated otherwise as it's integrated then into the PR system.

https://tvheadend.org/projects/tvheadend/wiki/CLA

@adamsutton
Copy link
Contributor

@cleanrock, without a signed agreement we cannot accept any code, this is part of or relicensing effort. CLAhub is a 3rd party github application, you must grant it basic access to your details to allow the app to work, nothing nefarious going on.

@ProfYaffle there are some weirdnesses with the integration, it doesn't always work, and unfortunately it's not under much dev at the moment, but I knew that before I started using it. I'm currently using it as guidance and manually verifying where it gives no input.

@ckarrie
Copy link
Contributor

ckarrie commented May 27, 2014

In the meanwhile I wrote a python post-processing script that detects (by a file containing the description) and removes (by lower filesize) duplicates: https://gist.github.com/ckarrie/1efbb8aaa8b8038b28f3

@suncore
Copy link

suncore commented Jun 2, 2014

I'm also really hoping this gets into TVH. This would be really nice.
@ckarrie, Thanks for your workaround. However this method leaves entries under failed recordings in the database. It would be nice if perhaps TVH could delete those database entries if file is missing.

@ckarrie
Copy link
Contributor

ckarrie commented Jun 2, 2014

@suncore OK, will take a look at your suggest.

@suncore
Copy link

suncore commented Jun 2, 2014

@cleanrock, I tested your patch but it seems that it only records the last showing, if there are multiple showings of the same episode. Did you see this too?

@ckarrie
Copy link
Contributor

ckarrie commented Jun 2, 2014

If the description of the show remains the same then my script doesn't work in your case. If this is the case then you just need to compare the name of the shows/serials.

@cleanrock
Copy link
Contributor Author

I signed the CLA using form on https://tvheadend.org/projects/tvheadend/wiki/CLA.
@suncore,
I have not seen that
My branch is pretty far behind tvheadend/master by now though, but i doubt that is the reason.

@suncore
Copy link

suncore commented Jun 5, 2014

Great! Thanks.
I guess it could be because of how the list is sorted. If there is no order to the list then the duplicate-comparison may be done backwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants