New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid dups #301
Avoid dups #301
Conversation
|
@cleanrock First question: Hi, could you please sign the CLA to get this in TVH? Second: Is it possible to compare the description to avoid duplicates? |
|
That looks odd, if i agree it looks like jasonm will have write access to my public repos. |
|
@cleanrock That isn't the intention - it should just record on github that you've agreed and then it's all done. No hijacking intended, I'm sure of that. @adamsutton, any comment, perhaps from the perspective of the CLA 'quirks' you've been seeing? If you have no intention of pushing further code, you can sign it offline, but I believe the github approach is mandated otherwise as it's integrated then into the PR system. |
|
@cleanrock, without a signed agreement we cannot accept any code, this is part of or relicensing effort. CLAhub is a 3rd party github application, you must grant it basic access to your details to allow the app to work, nothing nefarious going on. @ProfYaffle there are some weirdnesses with the integration, it doesn't always work, and unfortunately it's not under much dev at the moment, but I knew that before I started using it. I'm currently using it as guidance and manually verifying where it gives no input. |
|
In the meanwhile I wrote a python post-processing script that detects (by a file containing the description) and removes (by lower filesize) duplicates: https://gist.github.com/ckarrie/1efbb8aaa8b8038b28f3 |
|
I'm also really hoping this gets into TVH. This would be really nice. |
|
@suncore OK, will take a look at your suggest. |
|
@cleanrock, I tested your patch but it seems that it only records the last showing, if there are multiple showings of the same episode. Did you see this too? |
|
If the description of the show remains the same then my script doesn't work in your case. If this is the case then you just need to compare the name of the shows/serials. |
|
I signed the CLA using form on https://tvheadend.org/projects/tvheadend/wiki/CLA. |
|
Great! Thanks. |
No description provided.