Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capmt rework #308

Merged
merged 3 commits into from Dec 4, 2013
Merged

Capmt rework #308

merged 3 commits into from Dec 4, 2013

Conversation

manio
Copy link
Contributor

@manio manio commented Dec 1, 2013

Please review.
If you want to see real changes just do 'git show -w' (there is a lot of indentation changes).

The new mode uses one domain socket connection for all subscribed
services. The CA_SET_PID and CA_SET_DESCR are received over same
socket connection instead of one UDP socket per adapter.

The minimum OSCam version for use with this mode is svn rev 9063.
@amet
Copy link
Contributor

amet commented Dec 1, 2013

tested, works well here with oscam 9064

one cosmetic issue, Capmt connection stays red in tvh settings even after it connects to oscam and starts receiving ecms

@amet
Copy link
Contributor

amet commented Dec 1, 2013

correction, I have a problem decrypting 2 services. new channel opens fine but it immediately stops already playing one, then they alternate stop/play as the ecms are retrieved.

@manio
Copy link
Contributor Author

manio commented Dec 2, 2013

I've tested simultaneous decrypting of multiple channels (from same transponder and also on different dvb adapters) - and it's working ok for me.
Anyone else can test it?

@Danmark
Copy link
Contributor

Danmark commented Dec 2, 2013

'git show -w' can be done directly on github like this.
https://github.com/tvheadend/tvheadend/pull/308/files?w=-1

in case you did not know.

@amet
Copy link
Contributor

amet commented Dec 3, 2013

@manio with the patch posted on #hts all is working well with stock oscam

The commit fixes simultaneous channel decryption.
We are enumerating services based on the generated seq value.
In fact it should be elementary stream PID, but currently
we can leave it until PMT code rework.

The CA_SET_PID and CA_SET_DESCR from OSCam was always set with
seq=0 leading to setting all keys always to first subscribed
service.
@manio
Copy link
Contributor Author

manio commented Dec 3, 2013

Thank you guys for testing!
@Danmark: Thanks, good tip :)
@adamsutton: I added the missed fix, so it's now ready for merge (please don't squash ;).

@adamsutton adamsutton merged commit a20fc72 into tvheadend:master Dec 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants