Fix French Subtitles #427
Closed
Fix French Subtitles #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Language is determined by this line in telext parser laG0_nat_opts_lookup[Gtriplet & 0xf][natopts & 0x7]; For a frenc char : Gtriplet is 0 natopts is 1 So language 4 detected = german. I changed this case (0,1) to France, not sure that won’t break german.
|
As requested by ckarrie on irc, this should be tested befored merge with german content. I'll check manually by testing characters one by one manually. |
|
@c0mm0n Test successful ;-) |
|
Thanks a lot. |
|
Fixed in master - commit c469807 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Language is determined by this line in telext parser
Line 170 :
For a french char :
Gtriplet is 0
natopts is 1
So language 4 detected = german.
I changed this case (0,1) to France, not sure that won’t break german.