Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webui] a bunch of improvements to the recordings section #445

Closed
wants to merge 8 commits into from

Conversation

Jalle19
Copy link
Contributor

@Jalle19 Jalle19 commented Aug 5, 2014

Fixes:

  • when a recording switches from "currently recording" to "finished", the "Upcoming recordings" window is now properly updated (the entry disappears) and "Finished recordings" is updated accordingly
  • when a recording changes state (e.g. if it's deleted) and it's visible in the EPG filter, the state icon will now be updated accordingly

Improvements:

  • the recording details dialog is now opened by pressing an Info icon instead of clicking the row itself
  • multiple recordings can now be selected
  • the "Add entry" button is now only visible in "Upcoming recordings" since it makes no sense in the other panels. In addition to this, a new button "Abort/unschedule" button is now available.
  • a "Delete selected" button is available on the other panels which (wait for it...) deletes the selected recordings
  • the Abort/Delete buttons that were previously in the Info details dialog have been removed

Various/dubios:

  • removes duplicate check from the general "delete selected" function in tablemgr.js. The button is greyed out unless a selection has been made. I can drop this if you want.

@perexg @adamsutton for review (only tested in Firefox)
@mpmc for testing

Someone with stronger JavaScript-fu will have to refactor some of this crap some day so we can re-use the code a bit more.

This way a finished/aborted recording correctly appears in the corresponding
tab without having to reload the page
This way the DVR status icon gets updated correctly when a recording changes
state
…Delete,

the button is unclickable when nothing is selected
…s dialog

Also disable the oncellclicked callback which previously triggered the dialog

store.afterEdit(r);
store.fireEvent('updated', store, r,
Ext.data.Record.COMMIT);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not absolutely certain whether deleting this has any side effects, does anyone know?

@Jalle19
Copy link
Contributor Author

Jalle19 commented Aug 5, 2014

I was also thinking of moving the "Download" link from the recording details dialog to the panel buttons. Any thoughts on that?

@mpmc
Copy link
Contributor

mpmc commented Aug 5, 2014

@Jalle19 I like that idea! At least then if you know what the selected recording is you wont have to open the info dialog to download it!

A few more suggestions:-

  • Add an optional (default is hidden) 'Current programme' column to the Channel / EPG grid to show current programme on the channel.
  • Stop the DVB Inputs -> TV adapters tree from collapsing when you hit 'save' - You might want to make this an option as some might prefer it like it is!
  • Fix the 'starting around' column in the Auto recorder - You currently cannot set a start time of 00:00. The dropdown defaults to "0" which will then change to "00:00" if you leave "0" selected but once you hit save it vanishes! Oddly if you set your own value say "23:59" and hit 'save' then select it again it automatically takes a few hours off! Wha...? Haha!

@perexg
Copy link
Contributor

perexg commented Aug 6, 2014

Pulled, Merged, Rebased (the extra whitespaces removal) and Pushed to Master. Thanks.

@perexg perexg closed this Aug 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants