New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webui] a bunch of improvements to the recordings section #445
Conversation
This way a finished/aborted recording correctly appears in the corresponding tab without having to reload the page
This way the DVR status icon gets updated correctly when a recording changes state
…Delete, the button is unclickable when nothing is selected
…s dialog Also disable the oncellclicked callback which previously triggered the dialog
…alog in favor of the new panel buttons
|
|
||
| store.afterEdit(r); | ||
| store.fireEvent('updated', store, r, | ||
| Ext.data.Record.COMMIT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not absolutely certain whether deleting this has any side effects, does anyone know?
|
I was also thinking of moving the "Download" link from the recording details dialog to the panel buttons. Any thoughts on that? |
|
@Jalle19 I like that idea! At least then if you know what the selected recording is you wont have to open the info dialog to download it! A few more suggestions:-
|
|
Pulled, Merged, Rebased (the extra whitespaces removal) and Pushed to Master. Thanks. |
Fixes:
Improvements:
Various/dubios:
@perexg @adamsutton for review (only tested in Firefox)
@mpmc for testing
Someone with stronger JavaScript-fu will have to refactor some of this crap some day so we can re-use the code a bit more.