(partial) Fix libav transcoding for some people #449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
source: http://pastebin.com/fGLBsdqb Many thanks / all credit to @kvaster [12:15] < kvaster> I've made a patch for newer libav locally. Will be able to submit today a bit later. [12:17] < kvaster> http://pastebin.com/fGLBsdqb [12:23] < kvaster> it was just small api changes inside libav, I'm worried only about audio stream buffer sizes. [12:24] < kvaster> Anyway this is working for me at least.
… have the AV_ prefix on CODEC_ID_*
|
Merged. |
|
For completeness, another commit by BtbN has abandoned changes for newer ffmpg version. Possibly untested or broken. https://github.com/BtbN/tvheadend/compare/ffmpeg-2.1 He said it segfaulted however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks to @kvaster for his patch.
It does not break anything previous. And it does not fix completely.
This fixes for versions of ffmpeg and libav which are:
Why? the newest ffmpeg/libav versions have removed at some unknown recent commit in recent months the deprecated function
avcodec_decode_audio3. Which tvheadend currently still uses / depends upon.https://github.com/FFmpeg/FFmpeg/blob/97478ef5fe7dd2ff8da98e381de4a6b2b979b485/doc/APIchanges#L1029-1034
We should replace entirely the deprecated
_audio3function to the neweravcodec_decode_audio4function. And make a new minimum version requirement =54.40.0. However that change is more risk / complex than these ones. And not done yet. So is not included with this pull request.