scraping season/episode numbers for sky-it #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync with main repository
Extended the already present hack to extract such numbers from episode descriptions in Sky IT EPG data.
| en.e_num = atoi(ev.summary + match[2].rm_so); | ||
| save |= epg_episode_set_epnum(ee, &en, src); | ||
| for (i=0; patterns[i]; i++) { | ||
| regcomp(&preg, patterns[i], REG_ICASE | REG_EXTENDED); |
There was a problem hiding this comment.
I would move regcomp() to opentv_init() and regfree() to opentv_done() to save CPU ticks.. The patterns and precompiled regexes might be defined as global variables.
As suggested by perex, moved patterns and regexs as global variables and their management in opentv_init/opentv_done.
|
perexg, does it fit your recommendations? |
| @@ -815,12 +825,19 @@ void opentv_init ( void ) | |||
| if ((m = hts_settings_load("epggrab/opentv/prov"))) | |||
| _opentv_prov_load(m); | |||
| tvhlog(LOG_DEBUG, "opentv", "providers loaded"); | |||
|
|
|||
| /* Compile some recurring regular-expressions */ | |||
| for (i = 0; _opentv_se_num_patterns[i]; i++) ; /* count the available patterns (NULL-terminated array)*/ | |||
There was a problem hiding this comment.
I would prefer to use ARRAY_SIZE() to avoid this loop. Don't forget to remove the last NULL from _opentv_se_num_patterns[].
- make use of ARRAY_SIZE macro; - missing static keyword for global variables; - better patterns for sky-it with possibility to support a description without season specification; - debug messages;
|
Done. Sorry for the NULL-terminating array, but I was thinking about dynamic structures. |
perexg
added a commit
that referenced
this pull request
Sep 13, 2014
scraping season/episode numbers for sky-it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the already present hack to extract such numbers from episode descriptions in Sky IT EPG data.