IPTV Radio support #52
Conversation
Added service type for IPTV and IPTV radio for easier access in some software (like XBMC).
|
It's not working for me. In the web interface i checked the radio button, but XBMC won't see it as a radio channel. |
|
Sorry for not being specific enough. I've created separated service type ST_IPTV_RADIO with string "IPTV Radio". I'll also submit PR to XBMC after this is merged to tvheadend. Or I may use the same tag for IPTV radio and DVB-T radio. |
|
Ah ok, i just changed the string from IPTV Radio to Radio and now it is working under XBMC. Thanx :) |
|
Hi, I think you should handle IPTV radio channels the same way as DVB radio channels are handled in tvheadend. That way you don't need to change anything in XBMC, as XBMC already detects these kind of radio channels without problem. stealthblade already tested it this way and it looks like it works OK. |
|
Thank you for your comments. I'll update this later today. |
Tvheadend now uses same radio type ST_RADIO for DVB and IPTV radios. Otherwise IPTV streams have ST_IPTV type.
|
I use this fix in my version of tvheadend, and it works great in xbmc, hope we will soon see this in master also. |
|
i discovered the uncorrect handling of IPTV radio as well. would be great to see this fix in master. |
|
Would love it to see this added to the master! |
|
Can this feature be added to the master? :) |
|
@StealthBlade I think the answer is yes we want it included but I think there was some feedback based on a review a few weeks ago that appears to have been missed off. I'll post below: @ntadej these are @john-tornblom comments on the PR:
|
|
@john-tornblom The patch adds a new column to the IPTV configuration with check box, which is checked, if a channel is audio-only/radio. I've also thought about autodetection. The problem is, that tvheadend currently detects all available streams on first playback. We could enable that tvheadend opens each IPTV channel once when added to detect, if it's radio, but this can take time. (Our IPTV provider has in total about 200 channels and I import them to tvheadend by a script.) |
|
I also don't see any sense in autodetecting iptv radio channels. IPTV services need to be inserted into tvheadend manually (may it be a human or a script). Which means that the one who knows the service name, ip, port, etc. also knows if it's a radio or tv channel (once again... it may be a human or a script). Autodetection would make sense if you implement autoscan feature for iptv services into tvheadend. For the current implementation I think that ntadej's radio checkbox is the way to go. |
|
Fair enough, I admit I've never actually looked at iptv code and john may be the same. These were just notes from an initial scan he did to figure out a plan for moving forward. Based on what you've said sounds like its a no brainer. I'll take a look tomorrow and see if we can't get it merged as I noted gujs is using in oe builds. Adam |
|
Hi Adam. We use this in OE for a long time now without any issues. I think it is safe to merge. |
|
@Gujs yeah I noticed, I was reviewing your build spec yesterday as I'm making more changes that will possibly affect you and was also interested to see what you might be included. Personally I don't see a big problem with including this, I just want to go through the code (need to learn a bit about IPTV) and check it won't affect other clients (i.e. Showtime). However from what I can see most clients simply ignore the services list so this won't affect them. |
| @@ -318,6 +318,7 @@ typedef void (pid_section_callback_t)(struct service *t, | |||
| ST_HDTV = 0x11, /* HDTV (MPEG2) */ | |||
| ST_AC_SDTV = 0x16, /* Advanced codec SDTV */ | |||
| ST_AC_HDTV = 0x19, /* Advanced codec HDTV */ | |||
| ST_IPTV = 0x30, /* IPTV */ | |||
There was a problem hiding this comment.
Why 0x30? I'm trying to understand where this has come from?
Why is it not set to one of the standard service types?
|
@ntadej @mikrohard @Gujs Ok, the one thing I don't get is why this is using an IPTV specific service type, does XBMC somehow handle this? what's the reasoning and where does the number come from? I can't see any reference to it in any docs (but I'm probably not looking very hard ;) ). Anyway this is how I would do it: adamsutton/tvheadend@master...feature;iptv-radio Based on almost no knowledge of IPTV, so forgive the ignorance. |
|
AFAIK XBMC doesn't need an IPTV specific service type. It's just important to flag a radio channel as ST_RADIO... everything else is considered to be a tv channel (it does not matter if dvb or iptv). |
|
OK, I'm closing this. I've merged my variant. The main reason is that eventually we may improve things to have some sort of better detection and there are other thoughts on improving service selection base on type. So using a more compatible approach makes more sense. However to ensure we stay compatible with this PR I parse the "radio" flag from config and migrate to stype=ST_RADIO. |
|
Is it possible to make a difference to see which one is recognized as radio channel and tv channel? |
Added service type for IPTV and IPTV radio for easier access in some software (like XBMC).