Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBUI: update icon broadcast_details to looks better and change icon net... #536

Closed
wants to merge 2 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Oct 30, 2014

...works in color blue

@ProfYaffle
Copy link
Member

@PiterEL Just a thought - can you confirm that these icons are your own work, please?

I was also wondering if - perhaps when you've finished - we need to take a walk through everything and see if it all 'hangs together'. The advantage of the FamFamFam icons is that they were an obvious family, so we may need to tweak your changes afterwards to get them to a common look-and-feel. Make sense?

@ghost
Copy link
Author

ghost commented Oct 30, 2014

No. I search good icon in internet and changed size to looks good. I try now to harmonized with the FamFamFam icons.

@ProfYaffle
Copy link
Member

@PiterEL Okay, then let's do this... we can't be using icons if they're someone else's property, so... if you finish making the big changes you want to, then we can take a walk through it and see:

  1. Whether any FamFamFam icons should be reinstated
  2. Whether there are alternative royalty-free icons we could use instead
  3. Whether the look-and-feel is consistent enough
  4. Whether any changes have been too radical
  5. Whether the help text needs further updating (I think there's some good text in the old help files that we've maybe lost on the way)
  6. How we get the help text to match the wiki pages

... etc.

I'll help with this, and I know a couple of others will as well.

I'd also suggest using github as somewhere to post more 'proof of concept' images. Not everyone is going to like every change, so posting some pictures to say 'I was thinking of changing it to look like this, what do you think?' would get some immediate feedback from the community. You can even do this with your PRs, so it's obvious what the interface would look like after your changes - that helps get a debate going before asking (nagging? 😄 ) @perexg to merge.

@ghost
Copy link
Author

ghost commented Oct 31, 2014

I get icon from web site where is free icon.

@ProfYaffle
Copy link
Member

Okay, that solves one concern - thanks - which web site? We should credit it as the source.

The rest of the look-and-feel (&c) comments stand, though, I think - if you can modify everything so it looks like a family, though, we'll be 90% of the way there.

@ghost
Copy link
Author

ghost commented Oct 31, 2014

For example:
http://www.fancyicons.com/

http://www.softicons.com/free-icons

and other but i dont remember it.

@perexg
Copy link
Contributor

perexg commented Oct 31, 2014

@PiterEL : I think that each added icon (if it's modified) should note that source in the commit message to retain credits. Could you do this for current PRs ?

@ghost
Copy link
Author

ghost commented Oct 31, 2014

I don't understand. I must add source url to icon ?

I can do this to icon which i remember. OK ?

@perexg
Copy link
Contributor

perexg commented Oct 31, 2014

Yes, something like this to identify the original icon source.

@ghost
Copy link
Author

ghost commented Oct 31, 2014

For network icon i can not find source. From next add icon i can remember to add source.

Ok done.
@perexg is the chance to do this issue: #2421 and #2443 ?

@perexg
Copy link
Contributor

perexg commented Oct 31, 2014

Merged.

@perexg perexg closed this Oct 31, 2014
@ghost ghost deleted the fix_broadcast branch October 31, 2014 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants