New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WEBUI: update icon broadcast_details to looks better and change icon net... #536
Conversation
…networks in color blue
|
@PiterEL Just a thought - can you confirm that these icons are your own work, please? I was also wondering if - perhaps when you've finished - we need to take a walk through everything and see if it all 'hangs together'. The advantage of the FamFamFam icons is that they were an obvious family, so we may need to tweak your changes afterwards to get them to a common look-and-feel. Make sense? |
|
No. I search good icon in internet and changed size to looks good. I try now to harmonized with the FamFamFam icons. |
|
@PiterEL Okay, then let's do this... we can't be using icons if they're someone else's property, so... if you finish making the big changes you want to, then we can take a walk through it and see:
... etc. I'll help with this, and I know a couple of others will as well. I'd also suggest using github as somewhere to post more 'proof of concept' images. Not everyone is going to like every change, so posting some pictures to say 'I was thinking of changing it to look like this, what do you think?' would get some immediate feedback from the community. You can even do this with your PRs, so it's obvious what the interface would look like after your changes - that helps get a debate going before asking (nagging? 😄 ) @perexg to merge. |
|
I get icon from web site where is free icon. |
|
Okay, that solves one concern - thanks - which web site? We should credit it as the source. The rest of the look-and-feel (&c) comments stand, though, I think - if you can modify everything so it looks like a family, though, we'll be 90% of the way there. |
|
For example: http://www.softicons.com/free-icons and other but i dont remember it. |
|
@PiterEL : I think that each added icon (if it's modified) should note that source in the commit message to retain credits. Could you do this for current PRs ? |
|
I don't understand. I must add source url to icon ? I can do this to icon which i remember. OK ? |
|
Yes, something like this to identify the original icon source. |
Update icon because to previous i have not source. For this is: http://www.softicons.com/system-icons/oxygen-icons-by-oxygen/actions-document-info-koffice-icon
|
For network icon i can not find source. From next add icon i can remember to add source. Ok done. |
|
Merged. |
...works in color blue