Better duplication handling, better #604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 5, 2015 16:26
- better subtitle handling
| @@ -291,9 +302,12 @@ typedef struct dvr_autorec_entry { | |||
| int dae_minduration; | |||
| int dae_maxduration; | |||
| int dae_retention; | |||
|
|
|||
|
Have you signed CLA ? |
|
Yes, I did sign the CLA. |
|
Is it fine now? |
|
Merged. Thanks. |
| @@ -1527,11 +1531,12 @@ htsp_method_updateDvrEntry(htsp_connection_t *htsp, htsmsg_t *in) | |||
| retention = htsmsg_get_u32_or_default(in, "retention", 0); | |||
| priority = htsmsg_get_u32_or_default(in, "priority", DVR_PRIO_NORMAL); | |||
| title = htsmsg_get_str(in, "title"); | |||
| subtitle = htsmsg_get_str(in, "title"); | |||
There was a problem hiding this comment.
Is this really correct? Shouldn't it be subtitle?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the following duplicated recording options:
For autorec, all potential recordings are scheduled, but duplicates are marked as "reruns". Those duplicates are then just ignored and deleted when the timer is due.
Meaning: deduping is deferred until the point of recording. That's much safer than deduping too early.