http: fix Accept-Encoding parsing #652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbenz
force-pushed
the
accept-encoding-fix
branch
from
35718e7
to
860f9e1
Compare
|
Merged. Thanks. |
stbenz
force-pushed
the
accept-encoding-fix
branch
from
6ddb2c6
to
79ad8d5
Compare
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http_encoding_valid() only worked, if the requested encoding was at the beginning of the Accept-Encoding header. This usually worked, as the function is only called with encoding "gzip" and "gzip" is usually at the beginning of the Accept-Encoding header.
But, when the HTML5 web player is opened in Google Chrome, it sends "Accept-Encoding: identity;q=1, *;q=0", which causes an endless loop.
This fix should do the correct parsing of the Accept-Encoding header according to http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.3