input: tvhdhomerun: Handle the device changing IP addresses #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -86,7 +86,7 @@ tvhdhomerun_device_class_get_title( idnode_t *in, const char *lang ) | |||
| static char buf[256]; | |||
| tvhdhomerun_device_t *hd = (tvhdhomerun_device_t *)in; | |||
| snprintf(buf, sizeof(buf), | |||
| "%s - %s", hd->hd_info.friendlyname, hd->hd_info.ip_address); | |||
| "%s - %s", hd->hd_info.friendlyname, inet_ntoa(hd->hd_info.ip_address)); | |||
There was a problem hiding this comment.
Pls, use tvh's tcp_get_str_from_ip() function here... inet_ntoa might not allow recursive calls (static return buffer).
|
Re to IRC: See - http://stackoverflow.com/questions/16010622/reasoning-behind-c-sockets-sockaddr-and-sockaddr-storage . You may retype between struct sockaddr_storage , sockaddr , struct sockaddr_in and struct sockaddr_in6 (according family value). If you like to compare IPv4 - use sin_addr member from sockaddr_in . I also suggest to fill sockaddr_storage with zeroes before first use. |
Previously the device detection loop would always ignore HDHomeRuns with the same UID as devices that had already been detected. This would not detect if an HDHomeRun changed IPs for any reason (e.g. APIPA, misconfigured DHCP server) while TVHeadend was running, requiring a restart to resume functionality. Instead, if a newly detected device has the same UID as an previously-detected one but a different IP address, destroy the old device and recreate it with the new IP address.
|
Merged. Thanks for this contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the device detection loop would always ignore HDHomeRuns
with the same UID as devices that had already been detected. This
would not detect if an HDHomeRun changed IPs for any reason (e.g.
APIPA, misconfigured DHCP server) while TVHeadend was running,
requiring a restart to resume functionality. Instead, if
a newly detected device has the same UID as an previously-detected
one but a different IP address, destroy the old device and recreate
it with the new IP address.