Various little fixes. #927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpmc
force-pushed
the
fix
branch
2 times, most recently
from
71e4f6b
to
a17e7fb
Compare
mpmc
force-pushed
the
fix
branch
3 times, most recently
from
9281849
to
cc86d4d
Compare
mpmc
force-pushed
the
fix
branch
9 times, most recently
from
b48c1e3
to
296b949
Compare
mpmc
force-pushed
the
fix
branch
3 times, most recently
from
025e12f
to
81d567e
Compare
|
The permissions fix was not correct. I tried to fix this in b86ac23 . Applied the other two commits. Merged. |
|
I had a feeling it wasn't right, but it seemed to work when I tried it, but hey-ho I'm no C developer (and it shows! 🤣 ). I really appreciate you fixing it and letting me know that I goofed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the "Basic" streaming and DVR options weren't set when creating users via the wizard setup. This commit adds those options as default.
Edit: Additional fixes.. I noticed some browsers will try and login using cached details sometimes causing a login loop when clicking the "Default Login" link, replacing it with /logout should hopefully prevent this.