2.3.1 Update #306
2.3.1 Update #306
Conversation
….com/twitter/bootstrap/commits/master) in regards to the 2.3.1 release
|
Sorry, didn't mean to make a separate issue—it's been a while since I've done pull requests. I can't remember how to tie a pull request to an already open issue. 😦 Original issue: #305. My bad! |
|
Cool - thanks! It's entirely fine to have an issue and a pull request to fix it. Normal, in fact. No worries. |
|
If you want to be really nice, you can also add the changes to |
|
Alright, I'll give it a shot! |
|
Oh dang, it just shows up like magic! That's great 😄 |
|
Indeed it does! This github thing is pretty neat. |
|
@thomas-mcdonald take a look and merge/release if it looks good. Also @dallas -- are we absolutely certain these are the only changes in 2.3.1? No CSS changes at all? Thanks! |
|
Pretty sure. I just walked through the commit history for the actual twitter/bootstrap repository since their release of 2.3.0 on Feb. 7. |
|
You can review all those commits using this compare view: twbs/bootstrap@v2.3.0...v2.3.1 |
|
Excellent, looks good.
|
|
sorry for the delay - now we are also ready -- if someone will compare. jlong/sass-bootstrap-defunct#56 anyway, the changes made by @dallas looks good 👍 |
|
Thanks! Just to be safe, I'll run my automated updater with another branch, |
|
Looks good! All changes match up. Closing in favor of the automatically merged changes, but thank you again for your pull. |
Copied commits directly from https://github.com/twitter/bootstrap/commits/master in regards to the 2.3.1 release