font-size: $basefont * .75; #13

Merged
merged 1 commit into from Dec 2, 2011

Conversation

Projects
None yet
2 participants
Contributor

chopan commented Nov 25, 2011

Ruby needs a leading zero, so you can do the multiplication on patterns.css.scss ".labels"

Member

thomas-mcdonald commented Nov 29, 2011

Are you sure a leading 0 is required?

sass-rails seems to be compiling it fine on my application:

/* line 951, /Users/tom/.rvm/gems/ruby-1.9.3-p0/gems/bootstrap-sass-1.4.0/vendor/assets/stylesheets/bootstrap/patterns.css.scss */
.label {
  padding: 1px 3px 2px;
  font-size: 9.75px;
  font-weight: bold;
...
Contributor

chopan commented Nov 29, 2011

i'm getting this with ruby 1.9.2

ruby-1.9.2-p290 :001 > 2 * .75
SyntaxError: (irb):1: no . floating literal anymore; put 0 before dot
2 * .75
^
(irb):1: syntax error, unexpected '.'
2 * .75
^
with sass-rails 3.1.4 and sass 3.1.10 i'm not getting an error but the result is always 0px

Member

thomas-mcdonald commented Nov 29, 2011

But the file is an SCSS file, rather than a ruby file, so it's not something that would be interpreted by ruby.

Anyhow, it does increase readability so I'll probably merge it in anyway.

Contributor

chopan commented Nov 29, 2011

thanks!

thomas-mcdonald pushed a commit that referenced this pull request Dec 2, 2011

Merge pull request #13 from chopan/master
a merge that may or may not be required.

@thomas-mcdonald thomas-mcdonald merged commit f8dce60 into twbs:master Dec 2, 2011

sporkd added a commit that referenced this pull request Jul 30, 2013

Merge pull request #13 from yabawock/issue-6
Less aggressive @include transformation (Closes #6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment