Checking for asset pipeline #284

Merged
merged 1 commit into from Feb 5, 2013

Conversation

Projects
None yet
3 participants
@puffy
Contributor

puffy commented Jan 29, 2013

In some cases asset pipeline (sprockets) used in Rails 3.0 and current checking for Rails version doesn't work.
Probably it's better to check for Sprockets definition. I'm using this fix in my project with Rails 3.0.

@trisweb

This comment has been minimized.

Show comment Hide comment
@trisweb

trisweb Feb 4, 2013

Contributor

This does seem like a better check. @thomas-mcdonald what do you think?

Contributor

trisweb commented Feb 4, 2013

This does seem like a better check. @thomas-mcdonald what do you think?

@thomas-mcdonald

This comment has been minimized.

Show comment Hide comment
@thomas-mcdonald

thomas-mcdonald Feb 5, 2013

Member

looks good to me 👍

Member

thomas-mcdonald commented Feb 5, 2013

looks good to me 👍

thomas-mcdonald added a commit that referenced this pull request Feb 5, 2013

Merge pull request #284 from ssherif/master
Change the checks for Asset Pipeline from the
version of Rails to the presence of Sprockets

@thomas-mcdonald thomas-mcdonald merged commit c5623d7 into twbs:master Feb 5, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment