2.3.1 Update #306

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@dallas

Copied commits directly from https://github.com/twitter/bootstrap/commits/master in regards to the 2.3.1 release

@dallas

Sorry, didn't mean to make a separate issue—it's been a while since I've done pull requests. I can't remember how to tie a pull request to an already open issue. 😦

Original issue: #305. My bad!

@trisweb

Cool - thanks! It's entirely fine to have an issue and a pull request to fix it. Normal, in fact. No worries.

@trisweb

If you want to be really nice, you can also add the changes to README.md and other files for the bootstrap-sass version change - it would be 2.3.1.0

@dallas

Alright, I'll give it a shot!

@dallas

Oh dang, it just shows up like magic! That's great 😄

@trisweb

Indeed it does! This github thing is pretty neat.

@trisweb

@thomas-mcdonald take a look and merge/release if it looks good.

Also @dallas -- are we absolutely certain these are the only changes in 2.3.1? No CSS changes at all? Thanks!

@dallas

Pretty sure. I just walked through the commit history for the actual twitter/bootstrap repository since their release of 2.3.0 on Feb. 7.

@dallas

You can review all those commits using this compare view: twbs/bootstrap@v2.3.0...v2.3.1

@trisweb

Excellent, looks good.

:shipit:

@m5o
m5o commented Mar 7, 2013

sorry for the delay - now we are also ready -- if someone will compare.

jlong/sass-bootstrap-defunct#56

anyway, the changes made by @dallas looks good 👍

@trisweb
@trisweb trisweb added a commit to trisweb/bootstrap-sass that referenced this pull request Mar 12, 2013
@trisweb trisweb Upgrade to 2.3.1 from official upstream. 4884e9a
@trisweb

Looks good! All changes match up. Closing in favor of the automatically merged changes, but thank you again for your pull.

@trisweb trisweb closed this Mar 12, 2013
@rroblak rroblak pushed a commit to insight-meditation-center/imc-bootstrap-sass that referenced this pull request Nov 9, 2015
@trisweb trisweb Upgrade to 2.3.1 from official upstream. d89cea1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment