Apply 2.3.1 update #307

Closed
wants to merge 6 commits into
from

Projects

None yet

3 participants

@tcaddy
tcaddy commented Mar 6, 2013

Updated to Bootstrap v2.3.1, trying to do it the "right" way:

  1. Modify update-bootstrap.sh to use a different git repo for sass-twitter-bootstrap (a fork that has been updated to 2.3.1), but make it pretty obvious and easy to change it back in future.
  2. Run the script
  3. Bump version in bootstrap-sass.gemspec
@m5o m5o commented on the diff Mar 7, 2013
update-bootstrap.sh
@@ -2,8 +2,17 @@
ROOT=`pwd`"/vendor/assets"
TMP='tmp/sass-twitter-bootstrap'
+
+# the normal sass-twitter-bootstrap repo hasn't been updated to 3.2.1 yet
@m5o
m5o Mar 7, 2013

sorry for the delay - now we are ready

jlong/sass-bootstrap-defunct#56

@trisweb
Contributor
trisweb commented Mar 12, 2013

I appreciate that you used the script! I will be running it again now so I apologize in advance if I use the official repo and close this pull.

@trisweb trisweb added a commit to trisweb/bootstrap-sass that referenced this pull request Mar 12, 2013
@trisweb trisweb Upgrade to 2.3.1 from official upstream. 4884e9a
@trisweb
Contributor
trisweb commented Mar 12, 2013

I checked my updates against yours and all looks good - though this wasn't current with our master - just so you're aware we've had a couple fixes since you forked. Going to close this and open a new pull based on the official.

@trisweb trisweb closed this Mar 12, 2013
@rroblak rroblak pushed a commit to insight-meditation-center/imc-bootstrap-sass that referenced this pull request Nov 9, 2015
@trisweb trisweb Upgrade to 2.3.1 from official upstream. d89cea1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment