Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for `sprockets-rails` 3 and `sprockets` 4. #965

Merged
merged 1 commit into from Sep 27, 2015

Conversation

Projects
None yet
4 participants
@lucasmazza
Copy link
Contributor

lucasmazza commented Sep 11, 2015

sprockets-rails 3 already precompiles any asset that is referenced by the font-path and image-path helpers, and sprockets 4 does not support Regexpes as the precompile flag.

Add support for `sprockets-rails` 3 and `sprockets` 4.
`sprockets-rails` 3 already precompiles any asset that is referenced by the `font-path`
and `image-path` helpers, and `sprockets` 4 does not support Regexpes as the
`precompile` flag.

glebm added a commit that referenced this pull request Sep 27, 2015

Merge pull request #965 from lucasmazza/lm-sprockets-rails-3
Add support for `sprockets-rails` 3 and `sprockets` 4.

@glebm glebm merged commit 0399482 into twbs:master Sep 27, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@glebm

This comment has been minimized.

Copy link
Contributor

glebm commented Sep 27, 2015

Thanks!

@Eric-Guo

This comment has been minimized.

Copy link

Eric-Guo commented Oct 6, 2015

I'm trying rails 5 and spent 2 hours to realize I need this fix, would be great if can release a new version to avoid other developer burning their time.

Eric-Guo added a commit to cloud-mes/demo that referenced this pull request Oct 6, 2015

@lucasmazza lucasmazza deleted the lucasmazza:lm-sprockets-rails-3 branch Oct 6, 2015

Eric-Guo added a commit to cloud-mes/demo that referenced this pull request Oct 7, 2015

Eric-Guo added a commit to cloud-mes/demo that referenced this pull request Oct 8, 2015

Eric-Guo added a commit to cloud-mes/demo that referenced this pull request Oct 9, 2015

Eric-Guo added a commit to cloud-mes/demo that referenced this pull request Oct 10, 2015

@fofr

This comment has been minimized.

Copy link
Contributor

fofr commented Nov 25, 2015

I believe the following may have introduced a breaking change:
v3.3.5...v3.3.6diff-db4fa8404e2c8c4f78edc5fcf857dd4dR11

When running the tests for https://github.com/alphagov/govuk_admin_template, a gem and tested against a dummy Rails 3 app, 3.3.6 has the following error:

/home/jenkins/bundles/govuk_admin_template_branches/ruby/2.1.0/gems/bootstrap-sass-3.3.6/lib/bootstrap-sass/engine.rb:11:in `block in <class:Engine>': uninitialized constant Sprockets::Rails (NameError)

@fofr fofr referenced this pull request Nov 25, 2015

Merged

Pin bootstrap-sass #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.