From 37ec7f6928ac2b7e1a8846d39948b099b7f3fd25 Mon Sep 17 00:00:00 2001 From: Brian Juul Andersen Date: Sat, 13 Jul 2019 09:04:49 +0200 Subject: [PATCH 1/3] Update collapse.md (#29025) Corrected minor spelling error. --- site/content/docs/4.3/components/collapse.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/content/docs/4.3/components/collapse.md b/site/content/docs/4.3/components/collapse.md index 0eed61ebcd57..5b8dc5ea192f 100644 --- a/site/content/docs/4.3/components/collapse.md +++ b/site/content/docs/4.3/components/collapse.md @@ -123,7 +123,7 @@ Using the [card]({{< docsref "/components/card" >}}) component, you can extend t ## Accessibility -Be sure to add `aria-expanded` to the control element. This attribute explicitly conveys the current state of the collapsible element tied to the control to screen readers and similar assistive technologies. If the collapsible element is closed by default, the attribute on the control element should have a value of `aria-expanded="false"`. If you've set the collapsible element to be open by default using the `show` class, set `aria-expanded="true"` on the control instead. The plugin will automatically toggle this attribute on the control based on whether or not the collapsible element has been opened or closed (via JavaScript, or because the user triggered another control element also tied to the same collapsbile element). If the control element's HTML element is not a button (e.g., an `` or `
`), the attribute `role="button"` should be added to the element. +Be sure to add `aria-expanded` to the control element. This attribute explicitly conveys the current state of the collapsible element tied to the control to screen readers and similar assistive technologies. If the collapsible element is closed by default, the attribute on the control element should have a value of `aria-expanded="false"`. If you've set the collapsible element to be open by default using the `show` class, set `aria-expanded="true"` on the control instead. The plugin will automatically toggle this attribute on the control based on whether or not the collapsible element has been opened or closed (via JavaScript, or because the user triggered another control element also tied to the same collapsible element). If the control element's HTML element is not a button (e.g., an `` or `
`), the attribute `role="button"` should be added to the element. If your control element is targeting a single collapsible element – i.e. the `data-target` attribute is pointing to an `id` selector – you should add the `aria-controls` attribute to the control element, containing the `id` of the collapsible element. Modern screen readers and similar assistive technologies make use of this attribute to provide users with additional shortcuts to navigate directly to the collapsible element itself. From cdb6504e4803538e28a251a7f9634df2d580cd3e Mon Sep 17 00:00:00 2001 From: Mark Otto Date: Sun, 14 Jul 2019 01:44:49 -0700 Subject: [PATCH 2/3] Drop breakpoint CSS custom properties (#29020) Media queries do not support CSS custom properties (CSS variables), so we've had some useless variables lying around since shipping v4. This finally removes them and the associated documentation content that explained the situation. Fixes #29012. --- scss/_root.scss | 4 --- .../docs/4.3/getting-started/theming.md | 27 ------------------- 2 files changed, 31 deletions(-) diff --git a/scss/_root.scss b/scss/_root.scss index ad550df3b49b..055ac32fb091 100644 --- a/scss/_root.scss +++ b/scss/_root.scss @@ -8,10 +8,6 @@ --#{$color}: #{$value}; } - @each $bp, $value in $grid-breakpoints { - --breakpoint-#{$bp}: #{$value}; - } - // Use `inspect` for lists so that quoted items keep the quotes. // See https://github.com/sass/sass/issues/2383#issuecomment-336349172 --font-family-sans-serif: #{inspect($font-family-sans-serif)}; diff --git a/site/content/docs/4.3/getting-started/theming.md b/site/content/docs/4.3/getting-started/theming.md index 227f32bbf6e4..df12851ff626 100644 --- a/site/content/docs/4.3/getting-started/theming.md +++ b/site/content/docs/4.3/getting-started/theming.md @@ -404,11 +404,6 @@ Here are the variables we include (note that the `:root` is required). They're l --danger: #dc3545; --light: #f8f9fa; --dark: #343a40; - --breakpoint-xs: 0; - --breakpoint-sm: 576px; - --breakpoint-md: 768px; - --breakpoint-lg: 992px; - --breakpoint-xl: 1200px; --font-family-sans-serif: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol"; --font-family-monospace: SFMono-Regular, Menlo, Monaco, Consolas, "Liberation Mono", "Courier New", monospace; } @@ -426,25 +421,3 @@ a { color: var(--blue); } {{< /highlight >}} - -### Breakpoint variables - -While we originally included breakpoints in our CSS variables (e.g., `--breakpoint-md`), **these are not supported in media queries**, but they can still be used _within_ rulesets in media queries. These breakpoint variables remain in the compiled CSS for backward compatibility given they can be utilized by JavaScript. [Learn more in the spec](https://www.w3.org/TR/css-variables-1/#using-variables). - -Here's an example of **what's not supported:** - -{{< highlight css >}} -@media (min-width: var(--breakpoint-sm)) { - ... -} -{{< /highlight >}} - -And here's an example of **what is supported:** - -{{< highlight css >}} -@media (min-width: 768px) { - .custom-element { - color: var(--primary); - } -} -{{< /highlight >}} From 6a9fd74a83b23a33cc5d07d9c38eb0c02bfb73f6 Mon Sep 17 00:00:00 2001 From: Sunny Dhoke Date: Sun, 14 Jul 2019 14:22:33 +0530 Subject: [PATCH 3/3] Added link to creative commons license (#29032) The previous link is dead one. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 6045d4cf2e9c..4a3bcef87441 100644 --- a/README.md +++ b/README.md @@ -210,4 +210,4 @@ Support this project by becoming a sponsor. Your logo will show up here with a l ## Copyright and license -Code and documentation copyright 2011-2019 the [Bootstrap Authors](https://github.com/twbs/bootstrap/graphs/contributors) and [Twitter, Inc.](https://twitter.com) Code released under the [MIT License](https://github.com/twbs/bootstrap/blob/master/LICENSE). Docs released under [Creative Commons](https://github.com/twbs/bootstrap/blob/master/docs/LICENSE). +Code and documentation copyright 2011-2019 the [Bootstrap Authors](https://github.com/twbs/bootstrap/graphs/contributors) and [Twitter, Inc.](https://twitter.com) Code released under the [MIT License](https://github.com/twbs/bootstrap/blob/master/LICENSE). Docs released under [Creative Commons](https://creativecommons.org/licenses/by/3.0/).