Skip to content

Commit

Permalink
Drop breakpoint CSS custom properties (#29020)
Browse files Browse the repository at this point in the history
Media queries do not support CSS custom properties (CSS variables), so we've had some useless variables lying around since shipping v4. This finally removes them and the associated documentation content that explained the situation.

Fixes #29012.
  • Loading branch information
mdo authored and XhmikosR committed Jul 14, 2019
1 parent 37ec7f6 commit cdb6504
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 31 deletions.
4 changes: 0 additions & 4 deletions scss/_root.scss
Expand Up @@ -8,10 +8,6 @@
--#{$color}: #{$value};
}

@each $bp, $value in $grid-breakpoints {
--breakpoint-#{$bp}: #{$value};
}

// Use `inspect` for lists so that quoted items keep the quotes.
// See https://github.com/sass/sass/issues/2383#issuecomment-336349172
--font-family-sans-serif: #{inspect($font-family-sans-serif)};
Expand Down
27 changes: 0 additions & 27 deletions site/content/docs/4.3/getting-started/theming.md
Expand Up @@ -404,11 +404,6 @@ Here are the variables we include (note that the `:root` is required). They're l
--danger: #dc3545;
--light: #f8f9fa;
--dark: #343a40;
--breakpoint-xs: 0;
--breakpoint-sm: 576px;
--breakpoint-md: 768px;
--breakpoint-lg: 992px;
--breakpoint-xl: 1200px;
--font-family-sans-serif: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol";
--font-family-monospace: SFMono-Regular, Menlo, Monaco, Consolas, "Liberation Mono", "Courier New", monospace;
}
Expand All @@ -426,25 +421,3 @@ a {
color: var(--blue);
}
{{< /highlight >}}

### Breakpoint variables

While we originally included breakpoints in our CSS variables (e.g., `--breakpoint-md`), **these are not supported in media queries**, but they can still be used _within_ rulesets in media queries. These breakpoint variables remain in the compiled CSS for backward compatibility given they can be utilized by JavaScript. [Learn more in the spec](https://www.w3.org/TR/css-variables-1/#using-variables).

Here's an example of **what's not supported:**

{{< highlight css >}}
@media (min-width: var(--breakpoint-sm)) {
...
}
{{< /highlight >}}

And here's an example of **what is supported:**

{{< highlight css >}}
@media (min-width: 768px) {
.custom-element {
color: var(--primary);
}
}
{{< /highlight >}}

0 comments on commit cdb6504

Please sign in to comment.