From d15a0247ce444eb15f79b8bf76f2bc10f8eeb71a Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Mon, 7 Dec 2020 19:10:20 +0200 Subject: [PATCH] Remove `SelectorEngine.matches()`. (#32339) It's basically unused. --- js/src/dom/selector-engine.js | 8 ++------ js/tests/unit/dom/selector-engine.spec.js | 8 -------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/js/src/dom/selector-engine.js b/js/src/dom/selector-engine.js index 3c407667c957..727df7518902 100644 --- a/js/src/dom/selector-engine.js +++ b/js/src/dom/selector-engine.js @@ -14,10 +14,6 @@ const NODE_TEXT = 3 const SelectorEngine = { - matches(element, selector) { - return element.matches(selector) - }, - find(selector, element = document.documentElement) { return [].concat(...Element.prototype.querySelectorAll.call(element, selector)) }, @@ -38,7 +34,7 @@ const SelectorEngine = { let ancestor = element.parentNode while (ancestor && ancestor.nodeType === Node.ELEMENT_NODE && ancestor.nodeType !== NODE_TEXT) { - if (this.matches(ancestor, selector)) { + if (ancestor.matches(selector)) { parents.push(ancestor) } @@ -66,7 +62,7 @@ const SelectorEngine = { let next = element.nextElementSibling while (next) { - if (this.matches(next, selector)) { + if (next.matches(selector)) { return [next] } diff --git a/js/tests/unit/dom/selector-engine.spec.js b/js/tests/unit/dom/selector-engine.spec.js index 781d0ce1b5cb..d108a2efbf7e 100644 --- a/js/tests/unit/dom/selector-engine.spec.js +++ b/js/tests/unit/dom/selector-engine.spec.js @@ -14,14 +14,6 @@ describe('SelectorEngine', () => { clearFixture() }) - describe('matches', () => { - it('should return matched elements', () => { - fixtureEl.innerHTML = '
' - - expect(SelectorEngine.matches(fixtureEl, 'div')).toEqual(true) - }) - }) - describe('find', () => { it('should find elements', () => { fixtureEl.innerHTML = '
'