From d9675539139c21503dce7e3c567dbaac856bb138 Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Thu, 15 Apr 2021 04:35:54 +0100 Subject: [PATCH 1/3] Remove aria-haspopup from dropdowns (#33624) `aria-haspopup="true"` is really intended to signal that an ARIA `menu` will be opened on activation. as a result, some assistive technologies will announce controls with `aria-haspopup="true"` as a menu or menu item (e.g. JAWS and NVDA). In addition, `aria-haspopup` seems to trigger a bug in Edge/Narrator where the `aria-expanded` state is not correctly announced at the moment when `aria-haspopup` is present. This now makes the dropdown button more like a generic disclosure widget control - see also https://www.w3.org/TR/wai-aria-practices-1.2/examples/disclosure/disclosure-navigation.html01 --- js/tests/unit/dropdown.js | 2 +- js/tests/visual/dropdown.html | 26 +++--- js/tests/visual/scrollspy.html | 2 +- js/tests/visual/tab.html | 2 +- .../docs/4.6/components/button-group.md | 10 +-- site/content/docs/4.6/components/dropdowns.md | 86 +++++++++---------- .../docs/4.6/components/input-group.md | 8 +- site/content/docs/4.6/components/navbar.md | 4 +- site/content/docs/4.6/components/navs.md | 4 +- site/content/docs/4.6/components/scrollspy.md | 4 +- .../docs/4.6/examples/jumbotron/index.html | 2 +- .../4.6/examples/navbar-bottom/index.html | 2 +- .../docs/4.6/examples/navbars/index.html | 18 ++-- .../docs/4.6/examples/offcanvas/index.html | 2 +- .../4.6/examples/starter-template/index.html | 2 +- site/layouts/partials/docs-navbar.html | 2 +- 16 files changed, 88 insertions(+), 88 deletions(-) diff --git a/js/tests/unit/dropdown.js b/js/tests/unit/dropdown.js index e4b959ea1821..b71a125dfc71 100644 --- a/js/tests/unit/dropdown.js +++ b/js/tests/unit/dropdown.js @@ -752,7 +752,7 @@ $(function () { var done = assert.async() var html = '