Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10324: Add opt-in note to tooltip docs #10338

Merged
merged 2 commits into from Sep 11, 2013
Merged

Fix #10324: Add opt-in note to tooltip docs #10338

merged 2 commits into from Sep 11, 2013

Conversation

juthilo
Copy link
Collaborator

@juthilo juthilo commented Aug 31, 2013

  • Re-added a note (now callout) about need to opt in to tooltip docs
  • Converted same note in popover section to callout

/to @cvrebert @mdo for review.

Fixes #10324.

* Re-added a note (now callout) about need to opt in to tooltip docs
* Converted same note in popover section to callout
@cvrebert
Copy link
Collaborator

I don't think the selector option is directly related to this?

@juthilo
Copy link
Collaborator Author

juthilo commented Aug 31, 2013

Oh, I just copied the existing thing from the popover section. But is that not how it works? You just call tooltip with no options on a jQuery selector you choose?

@cvrebert
Copy link
Collaborator

cvrebert commented Sep 1, 2013

Erm, let me correct myself and clarify. The selector option is merely not the only way to do the manual initialization, depending on one's circumstances.

@juthilo
Copy link
Collaborator Author

juthilo commented Sep 1, 2013

Ah, okay. I'm clearly undereducated here, but I'll happily patch in any text suggestions.

@juthilo
Copy link
Collaborator Author

juthilo commented Sep 10, 2013

Could I get some more feedback on this? Don't really know what the text should be anymore... 😃

@cvrebert
Copy link
Collaborator

Maybe we should just go with the v2.3.2 phrasing?:

For performance reasons, the tooltip and popover data-apis are opt in, meaning you must initialize them yourself.

@juthilo
Copy link
Collaborator Author

juthilo commented Sep 10, 2013

Cool, done! Ping @mdo to confirm new phrasing.

@mdo
Copy link
Member

mdo commented Sep 11, 2013

:shipit:

mdo added a commit that referenced this pull request Sep 11, 2013
Fix #10324: Add opt-in note to tooltip docs
@mdo mdo merged commit 6ea2893 into master Sep 11, 2013
@mdo mdo deleted the readd-optin-notes branch September 11, 2013 19:49
@mdo mdo mentioned this pull request Sep 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs missing notice that tooltip/popover data-api is opt-in only
3 participants