Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 'col-' grid classes to table cells removes their cell border in Firefox and IE #11623

Closed
dzwillia opened this issue Nov 26, 2013 · 6 comments
Closed
Labels
Milestone

Comments

@dzwillia
Copy link
Contributor

@dzwillia dzwillia commented Nov 26, 2013

Using the grid classes for sizing of columns in tables causes cell borders to not show in Firefox or IE. This is due to the position: relative style on these classes. Since table cells can't really have a position: relative, seems like an easy fix would just be to add the following CSS:

/* fix missing table cell borders when using 'col-' classes for column sizing */
table td[class*="col-"], table th[class*="col-"] {
  position: static;
}

Problem: http://jsfiddle.net/7GH6e/
Fixed: http://jsfiddle.net/7GH6e/1/

Let me know if you'd like me to submit a pull request to fix this.

@cvrebert
Copy link
Collaborator

@cvrebert cvrebert commented Nov 27, 2013

We're trying to avoid using CSS wildcard/substring selectors like those. It'd be better to modify the grid system mixins instead.
Although I'm not sure to what degree using the grid system in tables is intended to be supported in the first place. Probably should be.

@cvrebert
Copy link
Collaborator

@cvrebert cvrebert commented Nov 27, 2013

What versions of Firefox and IE? Which OSes?

@dzwillia
Copy link
Contributor Author

@dzwillia dzwillia commented Nov 27, 2013

IE 10.0.11 and FF 25.0.1 on Windows 7.

@dzwillia
Copy link
Contributor Author

@dzwillia dzwillia commented Nov 27, 2013

@cvrebert Yeah, I totally agree -- I was a big fan of this change with icons from BS 2.x => BS 3.x. I'm just using the same CSS wildcards that already exist in BS 3.0.2 (tables.less, around line 131). Since they're already there, it seemed to make sense to specify the same wildcard to do the override and fix the problem).

@mdo
Copy link
Member

@mdo mdo commented Dec 1, 2013

This also affects IE9, but strangely enough not IE8 in my quick test.

@mdo mdo mentioned this issue Dec 1, 2013
@mdo mdo closed this in cf40b5d Dec 1, 2013
@dzwillia
Copy link
Contributor Author

@dzwillia dzwillia commented Dec 17, 2013

@mdo: Any chance we can also add this fix to table th and table td in case folks aren't using table col? Lemme know... If so, I can create a quick pull request for ya...

stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014
…thin tables to unfuck borders in IE9/10 and Firefox
stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014
…thin tables to unfuck borders in IE9/10 and Firefox
cvrebert added a commit that referenced this issue Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants