New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `footer` support to `blockquote` #11660

Closed
mdo opened this Issue Dec 1, 2013 · 8 comments

Comments

Projects
None yet
3 participants
@mdo
Copy link
Member

mdo commented Dec 1, 2013

According to http://www.w3.org/html/wg/drafts/html/master/grouping-content.html#the-blockquote-element, the blockquote attribution in the HTML5 spec should be within a footer. Within that, specific references to bodies of works should be within cite elements. However, it also appears cite on it's own will suffice (without the footer).

This breaks backward compatibility if we go right into it, so we can't do that. #11408 got us close with the cite element, but that leaves out the footer element.

Whatever solution we implement should account for all of this, and update the docs accordingly (with examples and links to the above spec).

@adrientetar

This comment has been minimized.

Copy link

adrientetar commented Dec 1, 2013

@mdo You don't have to use footer it seems, there's an example without it:

<blockquote>
 The people recognize themselves in their commodities; they find their 
 soul in their automobile, hi-fi set, split-level home, kitchen equipment. 
 — <cite><a href="http://en.wikipedia.org/wiki/Herbert_Marcuse">Herbert Marcuse</a></cite>
 </blockquote>
@mdo

This comment has been minimized.

Copy link
Member Author

mdo commented Dec 1, 2013

@adridu59 Yup, I mentioned that in my opening comment:

However, it also appears cite on it's own will suffice (without the footer).

So, we need to support the footer and cite as immediate children, and then the cite as an optional child of the optional footer. Shouldn't be too bad—my only concerns are:

  1. Do we support the small or anything else there? Seems anything could work, but only footer and cite are mentioned in the spec.
  2. Do we use a class? I'd prefer that—using .blockquote-citation instead of a generic HTML element sounds way better than a handful of elements.
  3. No matter what, we'll need to support the existing small tag so we don't break backward compatibility.

Overall, not too bad, just have to wait for 3.1.

@adrientetar

This comment has been minimized.

Copy link

adrientetar commented Dec 1, 2013

@mdo Depends on whether you want to fully support the official spec. Also I'd pay attention to the fact that this is a nightly, things get dropped off of it sometimes.
Is Bootstrap intended to be backwards-compat so that people can do drop-in replacement? I've always seen it as a CSS starting point. That being said someone with lots of small tags shall get annoyed by this situations if he wants to upgrade.

@mdo

This comment has been minimized.

Copy link
Member Author

mdo commented Dec 1, 2013

@adridu59 Good point regarding the nightly stuff—we'll want a more official spec to pull from if we do update the blockquote citations (with `footer or anything else)

Is Bootstrap intended to be backwards-compat so that people can do drop-in replacement?

Individual use cases aside, we do have to version control our code.

That being said someone with lots of small tags shall get annoyed by this situations if he wants to upgrade.

We'd never remove it from the project until v4 if it made sense.

@adrientetar

This comment has been minimized.

Copy link

adrientetar commented Dec 1, 2013

@mdo HTML5 and stable specs... no comment ;)

@carasmo

This comment has been minimized.

Copy link

carasmo commented Dec 1, 2013

The HTML5 specs:

<blockquote> 
<p>♥ Bukowski in <a href="https://twitter.com/search?q=%23HTML5&src=hash">#HTML5</a> spec examples <a href="http://t.co/0FIEiYN1pC">http://t.co/0FIEiYN1pC</a></p&gt;
<cite>— karl dubost (@karlpro)  <a href="https://twitter.com/karlpro/statuses/370905307293442048">August 23, 2013</a></cite>  
</blockquote> 

There is no footer. Don't bother with it.

http://html5doctor.com/cite-and-blockquote-reloaded/

http://www.w3.org/html/wg/drafts/html/master/text-level-semantics.html#the-cite-element

Html5 doctor most recent stuff mentions footer > cite, wrap the footer around the cite for an edge case where a cite might also be used in the body of a blockquote.

The link you referenced above is using this set up:

 <figure>
 <blockquote>
 "That monster custom, who all sense doth eat
 Of habit's devil," <abbr title="et cetera">&c.</abbr> not in Folio

 "What a falling off was there !
 From me, whose love was of that dignity
 That it went hand in hand even with the vow
 I made to her in marriage, and to decline
 Upon a wretch."
 </blockquote>
 <footer>
 — <cite class="title">Shakespeare manual</cite> by <cite class="author">Frederick Gard Fleay</cite>, 
 p19 (in Google Books)
 </footer>
 </figure>

That's using a figure, footer, and cite. Most people have rejected this approach and more recent examples on other parts of the site use cite with no figure, footer, etc.

@adrientetar

This comment has been minimized.

Copy link

adrientetar commented Dec 1, 2013

Personally, I would be in favor of replacing <small> with <cite>. <cite> is already common in today's HTML5 so it seems like it ain't gonna go out. Semantically, it looks better than footer imo.
IDK if Bootstrap publishes a list of API changes with each release but it would be practical once <small> gets deprecated, whatever its successor is.

@mdo

This comment has been minimized.

Copy link
Member Author

mdo commented Dec 7, 2013

According to HTML5 Doctor, the footer is the best bet.

<blockquote>
  <p>
    As my fellow HTML5 Doctor, Oli Studholme has showed, people seldom quote exactly 
    – so sacrosanctity of the quoted text isn’t a useful ideal – and in print etc, 
    citations almost always appear as part of the quotation – it’s highly conventional.
  </p>
  <footer>
    — <cite><a href="http://www.brucelawson.co.uk/2013/on-citing-quotations-again/">Bruce Lawson</a></cite>
  </footer>
</blockquote>

Source: http://html5doctor.com/cite-and-blockquote-reloaded/.

I can get down with that.

@mdo mdo closed this in 393d523 Dec 15, 2013

@mdo mdo referenced this issue Dec 15, 2013

Closed

v3.1.0 ship list #11734

stempler pushed a commit to stempler/bootstrap that referenced this issue Apr 11, 2014

stempler pushed a commit to stempler/bootstrap that referenced this issue Nov 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment