Hiding tabs not screenreader friendly

[Willem-Siebe]

I see that hidden tabs use display:none, but for the same reason why you have introduced .hidden for toggling content, this is not enough... So, in my opinion the hidden tabs should use the same CSS as .hidden.

[Willem-Siebe]

Same for collapse.

[mdo]

Simply adding the CSS wasn't enough here. Need some JS perhaps to go with @fat?

[fat]

hm i don't follow – what do you want me to do, happy to make a change

[hnrch02]

Tab accessibility is provided by #14154 and collapse accessibility by #14147 / #14153.

[Willem-Siebe]

Nice, but do you also apply the correct CSS in that changes now? With that, I mean the same CSS that is used for .hidden.

[hnrch02]

@Willem-Siebe dfa2759 did that but according to @mdo that broke the plugins.

[mdo]

Yeah, for some reason the transitions were borked when I added visibility into the mix. Maybe I just missed something and didn't add it to the transitions that change display/height?

[j-r-t]

Why has visibility been added exactly? It has caused problems for me.

If one wants to animate the nav bar (eg fade in) and visibility has been set on this, it causes the element to be shown before the animation has even started.

[Willem-Siebe]

@jessertaylor , to make it screenreader friendly, just like .hidden. You really have to dig into that issue to understand. Anyway.... this commit 7dd72d8 deleted the visibility: hidden !important; part from .hidden, so I'm not sure if the work being done here is still usefull, have to dig into the issue again and read the twitter discussion about why it is removed first. But I already write it down here in case somebody missed the commit!

[patrickhlauke]

In all current screen reader/browser combinations (barring a few very edge-casey bugs), once something's display:none'd it's effectively removed from the DOM, as far as assistive technologies are concerned. so visibility:hidden is not necessary anymore. or...what issue was it that you were originally trying to address here?

[Willem-Siebe]

@patrickhlauke That was the issue Patrick, and since it's deleted now from .hidden I thought let's be so friendly to post that here if somebody missed it so that adjustments for tabs and collapse can also be made. I haven't tested this myself yet and did not read the discussion about removing visibility either, but for the same reason I asked to add visibility here it now looks like this can be deleted again. So if the community agrees and knows only display:none is enough, I'm happy with that ofcourse.