.modal-header min-height formula is wrong #16769

Closed
inferusvv opened this Issue Jul 5, 2015 · 2 comments

Projects

None yet

3 participants

@inferusvv

modals.less, line 82.

min-height: (@modal-title-padding + @modal-title-line-height);

First of all it returns not rounded value. Secondary if we not set title, header seems broken. Cross becomes near bottom border. I don't know, what was idea of this min-height, but I fixed it with this code:

min-height: round(@modal-title-padding * 2 + @font-size-h4 * @line-height-base);
@cvrebert cvrebert added the css label Jul 5, 2015
@cvrebert cvrebert changed the title from Modal header min-height counting wrong to .modal-header min-height formula is wrong Jul 5, 2015
@mdo
Member
mdo commented Jul 6, 2015

Have a before/after example?

@inferusvv

@mdo Nope, but you can do it yourself. Inspect modal title and remove it. You will see what is wrong

@mdo mdo added this to the v3.3.6 milestone Aug 5, 2015
@mdo mdo referenced this issue Aug 5, 2015
Closed

v3.3.6 ship list #16644

@mdo mdo added a commit that closed this issue Aug 5, 2015
@mdo mdo fixes #16769: use a clearfix on the .modal-header instead of a min-he…
…ight to avoid collapsing when only a dismiss button is available and no .modal-title
5758692
@mdo mdo closed this in 5758692 Aug 5, 2015
@cvrebert cvrebert removed the awaiting reply label Aug 5, 2015
@kkirsche kkirsche referenced this issue in elastic/kibana Feb 21, 2016
Merged

Update Bootstrap to 3.3.6 #6294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment