New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.form-control-label padding-left breaks non-grid forms #17498

Closed
MrOutput opened this Issue Sep 6, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@MrOutput

MrOutput commented Sep 6, 2015

This is a .form-control.form-control-lg with .form-control-label

screenshot from 2015-09-06 15-03-36

However, i have this issue with all labels regardless of control size

.form-control {
    padding: 0.5em 0em;
}

^fixes this. Instead of padding: 0.5em

also card images need to have width of 100%

@cvrebert cvrebert added css v4 labels Sep 6, 2015

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Sep 6, 2015

Member

Please open a separate issue regarding the card thing.

Member

cvrebert commented Sep 6, 2015

Please open a separate issue regarding the card thing.

@matt-hernandez

This comment has been minimized.

Show comment
Hide comment
@matt-hernandez

matt-hernandez Sep 21, 2015

Contributor

In the docs, it seems like the use of .form-control-label only gets brought up if you are using form controls and labels with the .col-* and .row classes.

Eliminating the left and right padding would override the .col-* classes, so maybe it would be best to just specify top and bottom padding.

Contributor

matt-hernandez commented Sep 21, 2015

In the docs, it seems like the use of .form-control-label only gets brought up if you are using form controls and labels with the .col-* and .row classes.

Eliminating the left and right padding would override the .col-* classes, so maybe it would be best to just specify top and bottom padding.

@cvrebert cvrebert changed the title from v4-dev form control labels (remove padding left) to .form-control-label padding-left breaks non-grid forms Dec 14, 2015

@cvrebert cvrebert added the confirmed label Dec 14, 2015

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Dec 14, 2015

Member

@mdo So, http://v4-alpha.getbootstrap.com/components/forms/#validation says to use .form-control-label to make labels pick up the form validation text color (regardless of the type of form),
but http://v4-alpha.getbootstrap.com/components/forms/#using-the-grid basically implies .form-control-label should only be used for grid-based forms
(and indeed, the padding-left on .form-control-label screws up the alignment of the label text in http://v4-alpha.getbootstrap.com/components/forms/#validation ).
Which is it?

Member

cvrebert commented Dec 14, 2015

@mdo So, http://v4-alpha.getbootstrap.com/components/forms/#validation says to use .form-control-label to make labels pick up the form validation text color (regardless of the type of form),
but http://v4-alpha.getbootstrap.com/components/forms/#using-the-grid basically implies .form-control-label should only be used for grid-based forms
(and indeed, the padding-left on .form-control-label screws up the alignment of the label text in http://v4-alpha.getbootstrap.com/components/forms/#validation ).
Which is it?

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo May 11, 2016

Member

Coming in #19141.

Member

mdo commented May 11, 2016

Coming in #19141.

@mdo mdo closed this May 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment