.form-control-label padding-left breaks non-grid forms #17498

Closed
MrOutput opened this Issue Sep 6, 2015 · 4 comments

Projects

None yet

4 participants

@MrOutput
MrOutput commented Sep 6, 2015

This is a .form-control.form-control-lg with .form-control-label

screenshot from 2015-09-06 15-03-36

However, i have this issue with all labels regardless of control size

.form-control {
    padding: 0.5em 0em;
}

^fixes this. Instead of padding: 0.5em

also card images need to have width of 100%

@cvrebert cvrebert added css v4 labels Sep 6, 2015
@cvrebert
Member
cvrebert commented Sep 6, 2015

Please open a separate issue regarding the card thing.

@matt-hernandez
Contributor

In the docs, it seems like the use of .form-control-label only gets brought up if you are using form controls and labels with the .col-* and .row classes.

Eliminating the left and right padding would override the .col-* classes, so maybe it would be best to just specify top and bottom padding.

@cvrebert cvrebert changed the title from v4-dev form control labels (remove padding left) to .form-control-label padding-left breaks non-grid forms Dec 14, 2015
@cvrebert cvrebert added the confirmed label Dec 14, 2015
@cvrebert
Member

@mdo So, http://v4-alpha.getbootstrap.com/components/forms/#validation says to use .form-control-label to make labels pick up the form validation text color (regardless of the type of form),
but http://v4-alpha.getbootstrap.com/components/forms/#using-the-grid basically implies .form-control-label should only be used for grid-based forms
(and indeed, the padding-left on .form-control-label screws up the alignment of the label text in http://v4-alpha.getbootstrap.com/components/forms/#validation ).
Which is it?

@cvrebert cvrebert added this to the v4.0.0-alpha.3 milestone Dec 14, 2015
@mdo
Member
mdo commented May 11, 2016

Coming in #19141.

@mdo mdo closed this May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment