Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for disabled inline radio/checkboxes #20799

Closed
TheSharpieOne opened this issue Sep 27, 2016 · 1 comment
Closed

Docs for disabled inline radio/checkboxes #20799

TheSharpieOne opened this issue Sep 27, 2016 · 1 comment
Labels

Comments

@TheSharpieOne
Copy link

@TheSharpieOne TheSharpieOne commented Sep 27, 2016

Similar to #20608, this ticket aims to address the "inline" radio/checkbox which use form-check-inline. It was not explicitly pointed out in the previous issue, which is my fault. Rather than reopen it, I am making this new ticket.
The disabled styles between the form-check and form-check-inline are inconsistent as can be seen in the image below.

form-check-v-form-check-inline

The docs do not clearly indicate how to mark a form-check-inline as disabled. See this pin for the code used in the image: http://codepen.io/TheSharpieOne/pen/LRLErr?editors=1000

Relevant code: https://github.com/twbs/bootstrap/blob/v4.0.0-alpha.4/scss/_forms.scss#L241-L243

@cvrebert

This comment has been minimized.

Copy link
Member

@cvrebert cvrebert commented Sep 28, 2016

It would seem that either .form-check-inline is missing the color: $text-muted; of its .disabled .form-check-label counterpart, or that the markup scheme needs tweaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.