Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Coding Bug within docs #21445

Closed
IamManchanda opened this issue Dec 27, 2016 · 3 comments
Closed

Docs: Coding Bug within docs #21445

IamManchanda opened this issue Dec 27, 2016 · 3 comments

Comments

@IamManchanda
Copy link

IamManchanda commented Dec 27, 2016

Path --> /layout/grid/#how-it-works

Here is the bug

docs-bug

As per i see it , its doesn;t have to do anything with the framework but instead docs.min.css file with below styling

.bd-example-row-intro .container {
    padding: 1px; 
    border: 1px solid rgba(217,83,79,.5);
}

.bd-example-row-intro .row {
    padding: 1px;
    border: 1px solid rgba(2,117,216,.5);
}

If padding: 1px; is commented out, it will be back to the normal 15px padding to left and right and will resolve the issue respectively

@IamManchanda
Copy link
Author

IamManchanda commented Dec 27, 2016

@mdo Best Option would be to remove the bd-example-row-intro class from the parent div of the container div . as removing it is just simply resolving the issue completely including those unneccesary border outlines. Also , other examples within the page doesn't include this class and isn't facing any such issue

@Starsam80
Copy link
Contributor

Starsam80 commented Dec 27, 2016

I think this is intentional. If you actually take a look at the docs it mentions those outlines:

- Containers (outlined in blue above) provide a means to center your site's contents. Use `.container` for fixed width or `.container-fluid` for full width.
- Rows (outlined in red above) are horizontal groups of columns that ensure your columns are lined up properly. We use the negative margin method on `.row` to ensure all your content is aligned properly down the left side.

I assume the padding: 1px is just to make it stand out a little bit more. Ah, I see the issue now. Yes, the .bd-example-row-intro .container selector does cause issues, however I don't think outright removing the .bd-example-row-intro class is a good idea

@mdo
Copy link
Member

mdo commented Dec 27, 2016

Ah, yeah, I meant to come back to this. The borders aren't doing what I wanted them to to show how things overlap and make use of the negative margin. Going to remove it outright instead of fiddling with it for now. Thanks for reporting!

@mdo mdo added this to the v4.0.0-alpha.6 milestone Dec 27, 2016
@mdo mdo closed this as completed in dac31eb Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants