New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize header, footer, and content language #22092

Closed
vmike245 opened this Issue Mar 1, 2017 · 3 comments

Comments

Projects
5 participants
@vmike245

vmike245 commented Mar 1, 2017

Currently there is not a standard with how bootstrap refers to the header, footer, and content of an element. There are at least 4 items which fall into this category:

  • Tooltips
    • Content: tooltip-inner
  • Modals
    • Header: modal-header
    • Content: modal-body
    • Footer: modal-footer
  • Card
    • Header: card-header
    • Content: card-block
    • Footer: card-footer
  • Popover
    • Header: popover-title
    • Content: popover-content

For the most part the header and footer format is the same, but the content section seems to be on a per component basis. I would suggest standardizing the language around these sections to improve discoverability. If a user who has used cards before tries to use a modal, the first things they will try is modal-header, modal-block, modal-footer since that is what they used for card. Currently only 2 out of 3 of those will work. I think everyone would agree that a discoverable API is a very important part of a successful service and drastically improves ease of use.

@bkdotcom

This comment has been minimized.

Show comment
Hide comment
@bkdotcom

bkdotcom Mar 1, 2017

Contributor

I vote for "body" (which is semantically similar to table markup: <thead>,<tbody>, & <tfoot>)

Contributor

bkdotcom commented Mar 1, 2017

I vote for "body" (which is semantically similar to table markup: <thead>,<tbody>, & <tfoot>)

@Oxicode

This comment has been minimized.

Show comment
Hide comment
@Oxicode

Oxicode commented Mar 3, 2017

+1 body

@mdo mdo added the has-pr label Jun 15, 2017

mdo added a commit that referenced this issue Jun 15, 2017

Rename popover classes
Part of an update to align the naming schemes across our components.

- Renames .popover-title to .popover-header
- Renames .popover-content to .popover-body

Refs: #22092

@mdo mdo added this to the v4.0.0-beta milestone Jun 15, 2017

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Jun 15, 2017

Member

Two PRs coming in #22828 and #22829 to update popover and card classes to match the modals. No changes to the tooltips given that's an odd one.

Member

mdo commented Jun 15, 2017

Two PRs coming in #22828 and #22829 to update popover and card classes to match the modals. No changes to the tooltips given that's an odd one.

@mdo mdo added this to Safe to merge in v4 Beta 1 Jun 15, 2017

@mdo mdo closed this in #22828 Jun 15, 2017

@mdo mdo moved this from Safe to merge to Shipped in v4 Beta 1 Jun 15, 2017

mdo added a commit that referenced this issue Jun 15, 2017

Rename popover classes
Part of an update to align the naming schemes across our components.

- Renames .popover-title to .popover-header
- Renames .popover-content to .popover-body

Refs: #22092

@mdo mdo referenced this issue Jun 15, 2017

Closed

Beta 1 ship list #21568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment