New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Too strong selectors #24140
Comments
I agree @joneff . |
It's all yours. |
Thanks @joneff |
What about anchors without a |
Yes, you are right @mdo. Can we use something like |
@mdo, yes named (as in For those who use the standard approach i.e. As an example of such links, if you have a slider widget with the slider part and two buttons for changing the value, you don't need tabindex nor href attribute on those because, per spec, you can only focus the widget itself and it manages the focus on its child items. To me, assuming that anyone using named anchors is doing so by using the name attribute and not the id attribute has much smaller impact than assuming that anyone not having href or tabindex attribute is using named anchor and in terms forcing them to do something about the color and / or text decoration. |
Definitely against |
@XhmikosR, if that's the case, then I am not sure why the above code exists anyway :) Using named anchors with |
Context is in the issue that code resolved: #19402. |
I think the current implementation, which is what GitHub is using too judging from @mdo's linked issue, seems fine. Anyway, just my 2 cents. |
Okay. So, I will close the PR for this. |
I think this issue can be closed now. |
I'm not sure why this is happening but this change creates a problem for our application. We have an application using https://github.com/vsymguysung/ember-cli-summernote 1.5.0 and after upgrading to 1.5.1 some styles from the application have changed. The reason is, that in the CSS used by the browser there is Also other visual problems occur after upgrading the version. |
Who had this idea anyway? supposed that a frameworks makes (my) life easier |
I have the same issue as @bmaehr . |
Same issue as @bmaehr |
Same issue :( the overwritten is too strong |
As far as I know there is no HTML standard which defines href as mandatory.
Have you ever thought, that an application not only uses bootstrap but also other libraries where it is not so easy to just add something? |
You probably want to read @mdo's last comment above for context. Links without Styling both differently is considered a best practice, since they do not behave the same. Placeholder links litteraly do nothing and should not look like hyperlinks. Would you have any valid use case demonstrating this could be wrong? |
…ight` on the `html` element already set on `body` fix(@clayui/css): Reboot don't set `text-align: left` on `body` due to RTL issues. See liferay#1743 fix(@clayui/css): Reboot remove `:focus-visible` future-proof rule fix(@clayui/css): Reboot remove uses of Bootstrap's `font-size` and `hover` mixin, we don't support it in Clay CSS fix(@clayui/css): Reboot remove Bootstrap's `text-align` reset on `th`. See liferay#2219 fix(@clayui/css): Reboot remove Bootstrap's "hand" cursor to non-disabled button elements. We don't support `$enable-pointer-cursor-for-buttons`. We can change the cursor to whatever we want in Clay CSS. fix(@clayui/css): Reboot use selector `[href]` for styling anchor links instead of `a` so we don't need to overwrite placeholder anchor styles with `a:not([href])`. Styling `<a tabindex="0">a link</a>` should be done with a class like `link-primary`. Trying to avoid going down twbs/bootstrap#24140
…ight` on the `html` element already set on `body` fix(@clayui/css): Reboot don't set `text-align: left` on `body` due to RTL issues. See liferay#1743 fix(@clayui/css): Reboot remove `:focus-visible` future-proof rule fix(@clayui/css): Reboot remove uses of Bootstrap's `font-size` and `hover` mixin, we don't support it in Clay CSS fix(@clayui/css): Reboot remove Bootstrap's `text-align` reset on `th`. See liferay#2219 fix(@clayui/css): Reboot remove Bootstrap's "hand" cursor to non-disabled button elements. We don't support `$enable-pointer-cursor-for-buttons`. We can change the cursor to whatever we want in Clay CSS. fix(@clayui/css): Reboot use selector `[href]` for styling anchor links instead of `a` so we don't need to overwrite placeholder anchor styles with `a:not([href])`. Styling `<a tabindex="0">a link</a>` should be done with a class like `link-primary`. Trying to avoid going down twbs/bootstrap#24140
The following selector Is a notch too strong (0, 2, 1) and overrides normal class names:
bootstrap/scss/_reboot.scss
Lines 208 to 220 in 6dd3d91
It could be
Note: Updated snippet to better reflect the purpose of the styling i.e. named anchors. Original selector was
a:not([href]):not([tabindex]):not([class])
The text was updated successfully, but these errors were encountered: