Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Select Border and Custom File Browser when active or focus not displaying properly #24597

Closed
jonnysp opened this issue Oct 30, 2017 · 5 comments

Comments

@jonnysp
Copy link
Contributor

jonnysp commented Oct 30, 2017

only the normal
the validation variant works

testet on FF and Chrome win 10

unbenannt-1

@mdo mdo added this to Inbox in v4 Beta 3 via automation Nov 7, 2017
@mdo
Copy link
Member

mdo commented Nov 7, 2017

Hmm, to do this right, we need -webkit-appearance: none on the <select>s... might have to merge custom select and this one after all. Let me think about it for a bit.

@jonnysp
Copy link
Contributor Author

jonnysp commented Nov 7, 2017

not that we talk past each other . I mean the thick border on focus, around the the custom select!
On validation it works but not on standard focus.

@mdo mdo added the has-pr label Nov 7, 2017
@mdo
Copy link
Member

mdo commented Nov 15, 2017

@jonnysp I fixed the thick dark border on focus of the custom file input in #24699. Custom selects are also good to go with the changes in that PR. However, there is a problem with regular <select>s where, given browser default styles, we need to make additional changes for focus styles to be applied there via box-shadow. You cannot style the shadows without resetting so much more for these macOS based browsers.

@mdo mdo moved this from Inbox to Ready to merge in v4 Beta 3 Nov 24, 2017
v4 Beta 3 automation moved this from Ready to merge to Shipped Nov 24, 2017
@mdo mdo mentioned this issue Nov 24, 2017
@jonnysp
Copy link
Contributor Author

jonnysp commented Jan 22, 2018

@mdo the border is again different in version 4

@victorwpbastos
Copy link

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4 Beta 3
  
Shipped
Development

No branches or pull requests

4 participants