Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.btn backgrounds #27002

Closed
MartijnCuppens opened this issue Jul 31, 2018 · 3 comments
Closed

.btn backgrounds #27002

MartijnCuppens opened this issue Jul 31, 2018 · 3 comments

Comments

@MartijnCuppens
Copy link
Member

a.btn doesn't have a background, button.btn has a background (browser default)
See https://codepen.io/MartijnCuppens/pen/pZpxmr

If we add background-color: transparent; to .btn the 2 elements are rendered the same. We can than also remove this line from the .btn-outline-* buttons.

@patrickhlauke
Copy link
Member

but .btn isn't meant to be used in isolation, but only in conjunction with more explicit secondary classes like .btn-primary http://getbootstrap.com/docs/4.1/components/buttons/

i guess we could normalize this, but it's not the intended use of .btn per se

@MartijnCuppens
Copy link
Member Author

MartijnCuppens commented Aug 1, 2018

I know, but if people want to extend the .btn functionality, I think the base should always render the same? And if we move the transparent background from the .btn-outline-* classes to the .btn, we also save a tiny bit of css.

@MartijnCuppens
Copy link
Member Author

Hmm, also the color is different for a.btn and button.btn. Maybe we should also fix this? And what color should we use, the default text color or the link color?

@mdo mdo added this to Inbox in v4.2 via automation Aug 24, 2018
@mdo mdo moved this from Inbox to Ready to merge in v4.2 Aug 24, 2018
@mdo mdo closed this as completed in #27003 Sep 2, 2018
v4.2 automation moved this from Ready to merge to Shipped Sep 2, 2018
@XhmikosR XhmikosR removed this from Shipped in v4.2 Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants