Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove breakpoint custom properties #29012

Closed
mdo opened this issue Jul 10, 2019 · 1 comment · Fixed by #29020
Closed

Remove breakpoint custom properties #29012

mdo opened this issue Jul 10, 2019 · 1 comment · Fixed by #29020
Labels

Comments

@mdo
Copy link
Member

@mdo mdo commented Jul 10, 2019

Mentioned by me in #28936: we cannot use CSS custom properties in media queries, so we should remove the breakpoint variables we have there currently.

/cc @twbs/css-review for feedback, as well as ideas on perhaps what to add if anything

@mdo mdo added css v5 labels Jul 10, 2019
@mdo mdo added this to Inbox in v5 via automation Jul 10, 2019
@MartijnCuppens

This comment has been minimized.

Copy link
Member

@MartijnCuppens MartijnCuppens commented Jul 10, 2019

Yup, we should remove those.

mdo added a commit that referenced this issue Jul 13, 2019
Media queries do not support CSS custom properties (CSS variables), so we've had some useless variables lying around since shipping v4. This finally removes them and the associated documentation content that explained the situation.

Fixes #29012.
@mdo mdo added the has-pr label Jul 13, 2019
v5 automation moved this from Inbox to Shipped Jul 14, 2019
XhmikosR added a commit that referenced this issue Jul 14, 2019
Media queries do not support CSS custom properties (CSS variables), so we've had some useless variables lying around since shipping v4. This finally removes them and the associated documentation content that explained the situation.

Fixes #29012.
@XhmikosR XhmikosR removed this from Shipped in v5 Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.