Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
The bootstrap 4.4 add function doesn't quite work right with sass compilation.
As an example, paste the following
You'll notice that the compiled css has some wonkiness:
One option is to interpolate the plus sign in the function, like so:
Rolling back to 4.3.1 cancels the issue.
P.S. out of curiosity: what words "Erroneous area" could mean in my case?
I can release 4.4.1 when ready, just ping me.
Now, even if we did have a dart sass build test, we wouldn't have noticed this either since compilation didn't fail.
I think we should add a note in the docs as a warning about the Sass implementation we use, and if people use another one issues might arise.
@twbs/css-review I checked this. #29743 (comment)) is a solution but it doesn't work on ruby-sass - https://www.sassmeister.com/gist/b8f21c26b379106438151b01ffd629ca
Can we ignore the ruby-sass ? because it is already unsupported.
If we concern this,